Hi Josh, Am Samstag, den 05.03.2011, 20:27 +0530 schrieb Joachim Breitner: > Am Mittwoch, den 02.03.2011, 10:57 -0800 schrieb Josh Triplett: > > Package: pidgin-blinklight > > Version: 0.11.1-1 > > Severity: normal > > > > Closing Pidgin while the light blinks can leave it turned on. Please > > consider adding an appropriate cleanup mechanism that ensures the light > > always gets turned off when Pidgin exits. > > correct, thanks for the report. Since I won’t be able to fix it right, > now, this is just a confirmation mail. Not sure when I’ll get around to > do it. As usual, patches accepted.
I just had a look at the code. This is actually non-trivial without some larger restructuring, as any possible on-going blinkings are hidden in the data parameter to timeout callbacks and the module has no global state (which I like). Since this is not too critical (I think), I’ll let this rest until a possible larger code-restructuring comes up later. Hmm. Maybe it is more critical for people who don’t use the thinkpad thinklight to blink. Greetings, Joachim -- Joachim "nomeata" Breitner Debian Developer nome...@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C JID: nome...@joachim-breitner.de | http://people.debian.org/~nomeata
signature.asc
Description: This is a digitally signed message part
