Bug#325706: Crawl: When Blade Hands spell in effect, uninitialistd char[] buffer may be printed.

[Ilya Kasnacheev]

Package: crawl
Version: 4.0.0beta26-5

When Blade Hands spell in effect, unititialised char[] may be printed, 
causing output of weird symbols and might crash the game (unconfirmed).
This is due to fight.cc code:
line 3706
           case TRAN_BLADE_HANDS:
               if (damage < HIT_MED)
                   strcpy( noise, "slash" );
               else if (damage < HIT_STRONG)
                   strcpy( noise, "slice" );
               break;
So, if damage >= HIT_STRONG, then 'noise' will not be initialised, 
passed through to function that will output it.
And Blade Hands really kick butt so that will happen starting from clvl 
15 at most.

Suggested fix:
           case TRAN_BLADE_HANDS:
               if (damage < HIT_MED)
                   strcpy( noise, "slash" );
               else if (damage < HIT_STRONG)
                   strcpy( noise, "slice" );
               else
                   strcpy( noise, "tear" );
               break;

Sorry for not providing a patch.



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]