-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 15/02/2011 23:09, Yves-Alexis Perez a écrit :
> forcemerge 592524 613563
> thanks
>
> On mar., 2011-02-15 at 18:57 +0100, Manuel Klein wrote:
>> Package: xfburn
>> Version: 0.4.3-1
>> Severity: normal
>>
>> Hi,
>>
>> In Data composition mode, I would use the new directory functionnality to
>> organize my burn in a heavy composition. Unfortunately, when clicking on
>> 'Proceed to burn', Xfburn crashed.
>>
>> This bug occurs as soon as we add at least one directory from 'Create
>> directory' function.
>>
>> It can be reproduced simply according to this steps:
>> - Select New Data Composition at launch
>> - Create a directory (let's name it "pipo")
>> - Click on Proceed to burn
>> *Segfault*
>>
>> I built xfburn from sources to collect backtrace provided in attachement.
>> On line 10 of traceback_xfburn_bt_full is the name of added directory.
>
> That looks like #592524 too though there was no backtrace on it :)
>
> Merging the too, will try to have a look at some point.
>
> Regards,
I'm not conviced that it's the same than #592524 because it doesn't look
like to happen at any time.
However I tried to solve my problem, and following patch for
xfburn-data-composition.c seems to correct my problem. Could you check it ?
Thanks
- --
Manu
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk1b6RUACgkQnyDZfoiOigk3lQCfeXmPkoelJARY9XwCXP7ejC0c
RzMAnRXc2hsE6+Jov0skINgnFEyTccar
=CpSn
-----END PGP SIGNATURE-----
1877c1877,1879
< basename = g_path_get_basename (src);
---
> /* Check names only for items not manually created (#613563) */
> if (type != DATA_COMPOSITION_TYPE_DIRECTORY || src != NULL) {
> basename = g_path_get_basename (src);
1879,1882c1881,1884
< /* check if the file has been renamed */
< if (strcmp (basename, name) != 0) {
< /* rename the iso_node */
< r = iso_node_set_name (node, name);
---
> /* check if the file has been renamed */
> if (strcmp (basename, name) != 0) {
> /* rename the iso_node */
> r = iso_node_set_name (node, name);
1884,1886c1886,1888
< if (r == 0) {
< /* The first string is the renamed name, the second one the
original name */
< xfce_warn (_("Duplicate filename '%s' for '%s'"), name, src);
---
> if (r == 0) {
> /* The first string is the renamed name, the second one the
> original name */
> xfce_warn (_("Duplicate filename '%s' for '%s'"), name, src);
1888,1890c1890,1892
< g_free (basename);
< g_free (name);
< g_free (src);
---
> g_free (basename);
> g_free (name);
> g_free (src);
1892c1894,1895
< continue;
---
> continue;
> }
1893a1897
> g_free (basename);
1896d1899
< g_free (basename);
