Hi,
On Sat, 12 Feb 2011, Steve Langasek wrote:
> On Sat, Feb 12, 2011 at 10:32:34PM +0100, Julien Cristau wrote:
> > > CFLAGS := $(CFLAGS) -Wall -g
>
> > That would be wrong. A package build shouldn't depend on random env
> > variables.
>
> Depend on, or respect?
>
> Why shouldn't we expect packages to honor extra CFLAGS set in the
> environment, and require sanitized environments with no $CFLAGS set for
> standard package builds?
The way to pass supplementary flags is now defined by dpkg-buildflags as
well (and it's DEB_CFLAGS_{APPEND,SET}).
> (Anyway, isn't setting $CFLAGS in the environment exactly what
> dpkg-buildpackage + dpkg-buildflags *does*?)
Yes currently. But dpkg-buildpackage will stop setting the variables and
packages should solely rely on dpkg-buildflags to get the proper values.
That's because most people do not want "debian/rules build" to behave
differently from dpkg-buildpackage.
That said helper tools like "dh" should be free to use dpkg-buildflags
to set environment variables that ./configure and other similar calls
can inspect and use.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Follow my Debian News ▶ http://RaphaelHertzog.com (English)
▶ http://RaphaelHertzog.fr (Français)
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
