Bug#609813: atftpd in daemon mode not listening on requested port number.

[tony mancill]

On 02/02/2011 03:00 PM, Len Sorensen wrote:
> On Wed, Jan 12, 2011 at 11:54:59PM -0500, tony mancill wrote:
>> On 01/12/2011 09:08 AM, Len Sorensen wrote:
>>> Package: atftpd
>>> Version: 0.7.dfsg-9.2
>>> Severity: important
>>>
>>> Version 0.7.dfsg-9.1 broke atftpd in daemon mode.  It now listens on a
>>> random port number rather than the port number it is told to listen on.
>>> Of course in inetd mode it works fine since inetd is responsible for
>>> listening.  0.7.dfsg-9 worked fine.  0.7.dfsg-9.2 is broken too.
>>
>> Since I performed the 0.7.dfsg-9.1 upload, I'll take responsibility for
>> another NMU upload including this patch (thanks for sorting out the
>> issue), provided that Ludovic Drolez is not planning to upload and is
>> agreeable to another non-maintainer upload.
> 
> This still hasn't been fixed and squeeze is releasing in a few days.
> 
> Now squeeze will have broken tftpd.

Hello Len,

The maintainer, Ludovic Drolez, responded to this bug report 3 weeks ago [1] and
indicated that he was uploading a new version.  It would have been rude (and
contra to Debian policy) for me to perform another NMU.

I think a strong case can be made to have the patched atftpd package uploaded to
stable-proposed-updates for inclusion in the first point release as soon as the
release occurs.

Ludovic, is there an upload forthcoming, or is it okay for me to upload an NMU
that includes Len's patch?  I'm attaching the debdiff for the upload.

Thank you,
tony


[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=609813#20

diff -u atftp-0.7.dfsg/tftpd.c atftp-0.7.dfsg/tftpd.c
--- atftp-0.7.dfsg/tftpd.c
+++ atftp-0.7.dfsg/tftpd.c
@@ -256,6 +256,10 @@
 
                if (!tftpd_port)
                     tftpd_port = sockaddr_get_port(&sa);
+               else {
+                    sa.ss_family = AF_INET;
+                    sockaddr_set_port(&sa, tftpd_port);
+               }
 
                freeaddrinfo(result);
           }
diff -u atftp-0.7.dfsg/debian/changelog atftp-0.7.dfsg/debian/changelog
--- atftp-0.7.dfsg/debian/changelog
+++ atftp-0.7.dfsg/debian/changelog
@@ -1,3 +1,11 @@
+atftp (0.7.dfsg-9.3) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Apply patch listen on requested port when in daemon mode.  
+    Thanks to Len Sorensen.  (Closes: #609813)
+
+ -- tony mancill <tmanc...@debian.org>  Wed, 12 Jan 2011 20:58:05 -0800
+
 atftp (0.7.dfsg-9.2) unstable; urgency=low
 
   * Non-maintainer upload.

signature.asc
Description: OpenPGP digital signature