On Sat, 2011-01-29 at 19:58 +0100, David Kalnischkies wrote: > On Sat, Jan 29, 2011 at 18:30, Adam D. Barratt <a...@adam-barratt.org.uk> > wrote: > > On Tue, 2011-01-25 at 18:41 +0100, Michael Vogt wrote: > >> Please unblock package apt > >> > >> The 0.8.10.2 upload fixes a potential endless loop in apt-ftparchive > > > > The fact that you describe this as a "potential" issue makes me think > > it's too late to fix it now, I'm afraid. The changelog says > > > > * ftparchive/apt-ftparchive.cc: > > - fix endless loop for multiple TranslationsWriters > > > > Is that a common scenario? > > The fix is one line (changing iterator to reverse_iterator) and will be a
The size of the fix isn't really the important factor when we're a week away from a scheduled release. > very common scenario as soon as ftpmaster will decide to split > out the LongDescription out of the Packages file, see [0]. With apt-ftparchive being run on ftp-master's side, or elsewhere? If the former, then I'm not actually sure it would be a problem; see below. > Potential in this regard as it is save as long as only one section > is worked on in the apt-ftparchive generate run but as soon as > multiple sections or archives are generated in one run it blows up > in an endless loop (or an endless select wait to be correct). Much of ftp-master's use of apt-ftparchive has been replaced with functionality internal to dak, which is able to use information from within the projectd database. So far as I can see, the only remaining regular use of apt-ftparchive itself is calling the "clean" command; I've CCed ftp-master for confirmation or other comments. The diff also includes a change to apt-cache.cc which certainly seems annoying, but probably not RC. Regards, Adam -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
