tag 611203 + patch
thanks

On Thu, 27 Jan 2011 00:07:28 +0100, Robert Luberda wrote:

> > Setting a user in .dictrc leads to an authentication failure when I
> > try to access a dictd on an i386 machine (dictd from testing) with a
> > dict client on an amd64 machine (version from stable).

> Thanks for the bug report, unfortunately I had some troubles while
> trying to compile & run dictd on our Debian amd64 machine.

Thanks for the quick reply!
 
> However I've  just looked into source codes and found the possible cause
> of the bug: the five following lines from the top of the md5.h file:
> 
> #ifdef __alpha
> typedef unsigned int uint32;
> #else
> typedef unsigned long uint32;
> #endif
> 
> This is obviously wrong for amd64, as unsigned long is 8-bytes on 64-bit
> platforms.

Ah, there it is; I only looked quickly into dict.c.
 
> I think these lines should be better replaced with something like this:
> 
> #include <stdint.h>
> typedef uint32_t uint32
> 
> Gregor,
> would you be so kind to recompile dictd with the above change in md5.h
> and check if it solves your the problem?

Sure.

*me fiddles around on the amd64 machine with not alot build tools*

Yeah, it works!

Cool.

I'm attaching the debdiff (sorry, no nice patch :)).


Thanks again,
gregor


-- 
 .''`.   http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe
   `-    NP: Beach Boys: Good Vibrations
diff -u dictd-1.10.11.dfsg/debian/changelog dictd-1.10.11.dfsg/debian/changelog
--- dictd-1.10.11.dfsg/debian/changelog
+++ dictd-1.10.11.dfsg/debian/changelog
@@ -1,3 +1,10 @@
+dictd (1.10.11.dfsg-2.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Patch md5.h (cf. #611203).
+
+ -- gregor herrmann <gre...@debian.org>  Thu, 27 Jan 2011 00:12:37 +0100
+
 dictd (1.10.11.dfsg-2) unstable; urgency=low
 
   * Suggests dictd-dictionary as an alternative to dict-gcide (closes: #477511).
only in patch2:
unchanged:
--- dictd-1.10.11.dfsg.orig/md5.h
+++ dictd-1.10.11.dfsg/md5.h
@@ -1,11 +1,8 @@
 #ifndef MD5_H
 #define MD5_H
 
-#ifdef __alpha
-typedef unsigned int uint32;
-#else
-typedef unsigned long uint32;
-#endif
+#include <stdint.h>
+typedef uint32_t uint32;
 
 struct MD5Context {
 	uint32 buf[4];

Attachment: signature.asc
Description: Digital signature

Reply via email to