tag 610614 - patch
quit

On Thu, 20 Jan 2011 14:12:37 +0100
Daniel Baumann <dan...@debian.org> wrote:

> In order to make that possible, we do have a few feature requests for
> multistrap. The first is to have a possibility to inject debconf
> preseeding files.

I think support for this already exists in multistrap:

 setupscript=/path/to/setup.sh

setupscript is run after the packages have been unpacked but before any
configuration is done. It is passed the architecture being processed
and the directory where it is operating.

From the manpage/POD:

Once multistrap has unpacked the downloaded packages, the setup.sh can
be called, passing the location and architecture of the root
filesystem, so that other fine tuning can take place. At this stage,
any operations inside the rootfs must not try to execute any binaries
within the rootfs.

I'll update that section to make the warning conditional on the rootfs
not being a native one.

> Nik Lutz, a co-worker of mine, prepared a patch which i've
> successfully tested. I'll attach it to this bug as soon as i got the
> bug number for it. Please let me know what think of it.

I don't like the way the patch proposes to do this. Let me know if
there is a problem with the setupsh support but it would seem to
operate in the same manner. The patch method precludes / hides allowing
non-native to use the same support by handling the preseeding in the
configsh.

setupsh and configsh are hangovers from the previous emdebian-rootfs
package but can still be useful.

The patch also looks like it tries to assert that every multistrap
config file has to be modified to add a blank line. That's simply not
going to fly. All options like this have to be entirely optional -
including the line simply not existing. On a sidenote, system cp and
system cat look a lot like shell rather than perl. 

The bug should stay open even if setupsh works - that allows the
documentation to be updated.

-- 


Neil Williams
=============
http://www.linux.codehelp.co.uk/

Attachment: pgpt1cTUKlktu.pgp
Description: PGP signature

Reply via email to