Package: libcanberra0 Version: 0.24-1 Severity: important Tag: patch
ca_get_data_home sets e to NULL, yet returns CA_SUCCESS, and get_last_change fails to properly check for this. This leads to annoying segfaults in emacs, among other programs. Don Armstrong -- Let us chat together a moment, my friend. There are still several hours until dawn, and I have the whole day to sleep. -- Count Orlock in _Nosferatu (1922)_ http://www.donarmstrong.com http://rzlab.ucr.edu
diff -u libcanberra-0.24/debian/changelog libcanberra-0.24/debian/changelog --- libcanberra-0.24/debian/changelog +++ libcanberra-0.24/debian/changelog @@ -1,3 +1,10 @@ +libcanberra (0.24-2) unstable; urgency=low + + * Fix segfault when ca_get_data_home sets e to NULL, yet returns + CA_SUCCESS. + + -- Don Armstrong <d...@debian.org> Fri, 21 Jan 2011 17:06:51 -0800 + libcanberra (0.24-1) unstable; urgency=low * New upstream version: only in patch2: unchanged: --- libcanberra-0.24.orig/src/cache.c +++ libcanberra-0.24/src/cache.c @@ -391,6 +391,8 @@ if ((ret = ca_get_data_home(&e)) < 0) goto finish; + if (!e) + goto finish; if (!(k = ca_new(char, strlen(e) + sizeof("/sounds")))) { ca_free(e);