Does not fit release blocker criteria, but would still be *very* nice
to have for the release, as it easily fixes / papers over a rather
annoying / stupid (from the user's point of view) bug:
When editing a report in design view, in Format / Page, if one
changes the left or right margin, then all changed settings for all
margins (and other things) are lost and come back their value at
opening of that dialog. This makes it impossible to set the left or
right margin.
This may not be the "real" fix attacking the root cause, but it at
least hides the problem for the user.
--
Lionelx
>From b3cf61a58d5a3cf32e1372a102d3ef5d2c477fb5 Mon Sep 17 00:00:00 2001
From: Lionel Elie Mamane <lio...@mamane.lu>
Date: Sat, 15 Jan 2011 05:39:40 +0100
Subject: [PATCH] i#116187: report left/right page margin setting ignored on Unix 64 bit
---
reportdesign/source/ui/report/ReportController.cxx | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/reportdesign/source/ui/report/ReportController.cxx b/reportdesign/source/ui/report/ReportController.cxx
index 1af728c..9beed73 100644
--- a/reportdesign/source/ui/report/ReportController.cxx
+++ b/reportdesign/source/ui/report/ReportController.cxx
@@ -2500,8 +2500,8 @@ void OReportController::openPageDialog(const uno::Reference<report::XSection>& _
if ( SFX_ITEM_SET == pSet->GetItemState( RPTUI_ID_LRSPACE,sal_True,&pItem))
{
- xProp->setPropertyValue(PROPERTY_LEFTMARGIN,uno::makeAny(static_cast<const SvxLRSpaceItem*>(pItem)->GetLeft()));
- xProp->setPropertyValue(PROPERTY_RIGHTMARGIN,uno::makeAny(static_cast<const SvxLRSpaceItem*>(pItem)->GetRight()));
+ xProp->setPropertyValue(PROPERTY_LEFTMARGIN,uno::makeAny((sal_Int32)static_cast<const SvxLRSpaceItem*>(pItem)->GetLeft()));
+ xProp->setPropertyValue(PROPERTY_RIGHTMARGIN,uno::makeAny((sal_Int32)static_cast<const SvxLRSpaceItem*>(pItem)->GetRight()));
}
if ( SFX_ITEM_SET == pSet->GetItemState( RPTUI_ID_ULSPACE,sal_True,&pItem))
{
--
1.7.2.3
