Hallo Sven,

Jan-Michael and I are discussing the options to properly create the
devices.  We both feel it's better to try to fix the issue in udev or
the kernel.  Jan-Michael may be able to put forth a bit of effort to
that end to help the maintainers of those packages.

On 13.01.2011 00:11, Sven Hartge wrote:
> (Note: you might want to document the fact one has to blacklist the
> mISDN drivers like hfcpci you want to use hisax, since the mISDN ones
> get automatically loaded and the i4l ones don't.)

Will have a look.  I'm still learning all the i4l voodoo.  You may want
to open a separate ticket on this to make sure it won't be forgotten.

> As is, the packages don't work, since the needed devices are missing and
> nobody creates them.

ACK.  Eventually this will have to be dealt with somewhere.  My hope is
we can get rid of hacks as much as possible to get isdnutils into a
maintainable state.

>>> Additionally the following code should IMHO be changed to use "-sf" to not
>>> fail if the link already exists:
>>>
>>> 91             if [ ! -e /dev/isdnctrl ]; then
>>> 92                 cd /dev && ln -sf isdnctrl0 isdnctrl
>>> 93             fi
>>
>> Thank you for this suggestion.  But I don't quite understand the need to
>> force the creation.  That's what the if-part is for, isn't it?
> 
> During the state of my system without any ISDN device nodes, the start
> script for isdnlog etc. complained about an already existing symlink.
> 
> This is because -e dereferences the symlink and if the target is not
> available, it will fail. So the correct solution here is not to use "ln
> -sf" but to use "[ -L /dev/isdnctl ]" to check for the existance of the
> symlink.

Well, -L is not the solution.  It would break when the file exists but
is not a symbolic link.  I've come to the conclusion that quite
surprisingly, your original suggestion is likely the way to go.  This is
due to the dereferencing you mentioned.  Essentially, there's three
possible states.

 a) file does not exist -> create
 b) file exists and points to valid target -> do nothing
 c) file exists but is a dangling symlink -> overwrite

I will update the package that is waiting for sponsorship.

Regards

Rolf



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to