Package: bacula-fd
Version: 5.0.2-2.2+b1
Severity: normal
Tags: patch

Hi,

If I run "/etc/init.d/bacula-fd start", and bacula-fd is already
running, then the init script fails and exits with status 1. This
caused me some trouble today when I had to reboot during an apt-get
upgrade (for unrelated reasons); when I tried to resume, completing the
upgrade failed because bacula had been started by the reboot, and
running "/etc/init.d/bacula-fd start" was erroring out.

Using --oknodo with start-stop-daemon seems to be the solution to this.
I checked other init scripts for precedence, and quite a few of the ones
I have use --oknodo, so I'm pretty sure it's a generally accepted
approach.

I'm reporting this against bacula-fd, but my patch applies to the other
daemons as well.

Thanks,
Corey


-- System Information:
Debian Release: 6.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.36 (SMP w/4 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/bash

Versions of packages bacula-fd depends on:
ii  bacula-common           5.0.2-2.2+b1     network backup, recovery and verif
ii  libacl1                 2.2.49-4         Access control list shared library
ii  libattr1                1:2.4.44-2       Extended attribute shared library
ii  libc6                   2.11.2-7         Embedded GNU C Library: Shared lib
ii  libgcc1                 1:4.4.5-10       GCC support library
ii  libpython2.6            2.6.6-8+b1       Shared Python runtime library (ver
ii  libssl0.9.8             0.9.8o-4         SSL shared libraries
ii  libstdc++6              4.4.5-10         The GNU Standard C++ Library v3
ii  libwrap0                7.6.q-19         Wietse Venema's TCP wrappers libra
ii  lsb-base                3.2-26           Linux Standard Base 3.2 init scrip
ii  zlib1g                  1:1.2.3.4.dfsg-3 compression library - runtime

bacula-fd recommends no packages.

Versions of packages bacula-fd suggests:
pn  bacula-traymonitor            <none>     (no description available)

-- no debconf information
diff --git a/debian/bacula-director-common.bacula-director.init b/debian/bacula-director-common.bacula-director.init
index 7596ba3..021fd87 100644
--- a/debian/bacula-director-common.bacula-director.init
+++ b/debian/bacula-director-common.bacula-director.init
@@ -56,7 +56,7 @@ kill_pid()
 do_start()
 {
 	start-stop-daemon --start --quiet --pidfile $PIDFILE \
-	--exec $DAEMON -- $ARGS
+	--oknodo --exec $DAEMON -- $ARGS
 }
 
 # do_stop()
diff --git a/debian/bacula-fd.init b/debian/bacula-fd.init
index 2df2245..3f98ca9 100644
--- a/debian/bacula-fd.init
+++ b/debian/bacula-fd.init
@@ -39,7 +39,7 @@ PIDFILE=/var/run/bacula/$NAME.$PORT.pid
 do_start()
 {
         start-stop-daemon --start --quiet --pidfile $PIDFILE \
-        --exec $DAEMON -- $ARGS
+        --oknodo --exec $DAEMON -- $ARGS
 }
 
 do_stop()
diff --git a/debian/bacula-sd.init b/debian/bacula-sd.init
index f902982..f914645 100644
--- a/debian/bacula-sd.init
+++ b/debian/bacula-sd.init
@@ -37,7 +37,7 @@ PIDFILE=/var/run/bacula/$NAME.$PORT.pid
 do_start()
 {
         start-stop-daemon --start --quiet --pidfile $PIDFILE \
-        --exec $DAEMON -- $ARGS
+        --oknodo --exec $DAEMON -- $ARGS
 }
 
 do_stop()

Reply via email to