On Thu, 2010-12-23 at 11:07 +0200, Teodor MICU wrote: > 2010/12/22 Arthur de Jong <adej...@debian.org>: > > Indeed, some devices need to be created inside the chroot jail and > > are used by the cvs process. cvsd-buildroot should print a warning > > if the created devices could not be used. > > Right. The error was visible only to the client with an error message > like "could not open /dev/null".
You mean that cvsd-buildroot did not complain? Note that cvsd-buginfo also contains a prominent notice about the mount options. > > The formatting for CVSROOT/passwd files should be > > cvsuser:passwordhash:cvsd > > (assuming standard read-only setup). cvsd-passwd should set this up > > correctly and both cvsd-buildroot and cvsd-buginfo should report > > most configuration problems here. > > All the accounts on the imported repository were > "cvsuser:passwordhash:", meaning without the real system ID at the end > ":cvsd". Indeed cvsd-passwd adds automatically the ":cvsd" entry even > if not specified. cvsd-passwd should do what is most logical depending on the contents of cvsd.conf. The format of CVSROOT/passwd is described in the FAQ but it you have anything that should be added, improvements are welcome. > > Perhaps that could be added to the FAQ or README. > > Yes, that was my suggestion for this bug report. I've added an entry to the FAQ. > >> Also, I've put logging to "debug" and all operation (success or fail) will > >> print > >> this line on syslog: > >> | cvsd[5740]: debug: select() failed (ignored): Interrupted system call > >> > >> Is this something to take into account? > > > > The above line can be safely ignored. It only means that the call to > > select() was interrupted (probably due to the sub-process ending). The > > cvs process that is started does provide very little debugging > > information though and it is also hard to get extra info (see the FAQ > > for details). > > Ok, though doesn't sound right for successful operations or it > shouldn't be printed on any log level. Since I've got more questions about this from people who haven't read the FAQ and this does not provide much extra debugging info, I've removed the log message. Thanks for your feedback. -- -- arthur - adej...@debian.org - http://people.debian.org/~adejong --
signature.asc
Description: This is a digitally signed message part
