Michael Banck <[EMAIL PROTECTED]> writes: > Actually, we were prepared to just give in and send in a patch which > defined MAXHOSTNAMELEN/MAXPATHLEN in each offending file in case it is > not already, at least for Debian to apply. This is probably still a > good short-term measure for Debian's heimdal package, as a lot of > packages depend on heimdal for building. > > If you have interest in a more proper solution, I will see what we can > do to fix this up, get it reviewed and resubmitted to you.
The Heimdal way would be to add the defines to roken.h for those operating system they are missing. Most of the MAXPATHLEN is probably replaceable with asprintf & friends. For me it doesn't really matter if MAXPATHLEN is used or not. It really depends on how strongly you feel about the issue. I only concerned about code quality in this case, and the patch as it is doesn't cut it. And again, xgethostname is a bad variable name since most people will assosiate it with xmalloc. Love
pgpc3uGPVRY04.pgp
Description: PGP signature
