Package: acpi-support
Version: 0.138-4
Severity: normal
Tags: patch

var=`cat file | sed -e 's/ *$//'`

can be replaced by:

var=`sed -e 's/ *$//' file`

or:

read var <file

the later being most efficient.


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages acpi-support depends on:
ii  acpi-fakekey                  0.138-4    tool to generate fake key events
ii  acpi-support-base             0.138-4    scripts for handling base ACPI eve
ii  acpid                         1:2.0.7-1  Advanced Configuration and Power I
ii  lsb-base                      3.2-26     Linux Standard Base 3.2 init scrip
ii  pm-utils                      1.3.0-3    utilities and scripts for power ma
ii  x11-xserver-utils             7.5+2      X server utilities

Versions of packages acpi-support recommends:
ii  dbus                          1.2.24-3   simple interprocess messaging syst
pn  radeontool                    <none>     (no description available)
ii  vbetool                       1.1-2      run real-mode video BIOS code to a
pn  xscreensaver | gnome-screensa <none>     (no description available)

Versions of packages acpi-support suggests:
ii  rfkill                        0.4-1      tool for enabling and disabling wi
ii  xinput                        1.5.2-1    Runtime configuration and test of

-- no debconf information


Cheers,

-- 
Cristian
--- ./debian/acpi-support/usr/share/acpi-support/device-funcs.orig	2010-12-14 11:37:17.000000000 +0100
+++ ./debian/acpi-support/usr/share/acpi-support/device-funcs	2010-12-14 21:24:06.000000000 +0100
@@ -1,7 +1,7 @@
 
 DeviceConfig() {
-    manufacturer=`cat /sys/class/dmi/id/sys_vendor|sed -e 's/ *$//'`
-    model=`cat /sys/class/dmi/id/product_name|sed -e 's/ *$//'`
-    version=`cat /sys/class/dmi/id/product_version|sed -e 's/ *$//'`
-    bios_version=`cat /sys/class/dmi/id/bios_version|sed -e 's/ *$//'`
+    read manufacturer </sys/class/dmi/id/sys_vendor
+    read model </sys/class/dmi/id/product_name
+    read version </sys/class/dmi/id/product_version
+    read bios_version </sys/class/dmi/id/bios_version
 }

Reply via email to