Package: blop
Version: 0.2.8-5
Severity: wishlist
Tags: patch

Hi,

thanks for maintaining blop.

blop fails to build from source, if --as-needed is used as a linker flag, 
see [1,2].

Attached is a patch that fixes the problem by reordering libraries for the 
linker so that libraries appear after the file using these symbols from it.

The Makefile.in was rewritten by hand, but I hope that a correct one can also
be rebuilt using autotools from the Makefile.am.

Cheers,
    Stefan.
[1]:
<http://people.ubuntuwire.org/~lucas/ubuntu-nbs/32/blop_0.2.8-5_lubuntu32.buildlog>
[2]:
<http://people.ubuntuwire.org/~lucas/ubuntu-nbs/64/blop_0.2.8-5_lubuntu64.buildlog>

-- System Information:
Debian Release: squeeze/sid
  APT prefers natty-updates
  APT policy: (500, 'natty-updates'), (500, 'natty-security'), (500, 'natty')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.37-7-generic (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- blop-0.2.8.orig/src/Makefile.in
+++ blop-0.2.8/src/Makefile.in
@@ -138,7 +138,8 @@
 noinst_PROGRAMS = wavegen
 wavegen_SOURCES = wavegen.c wdatutil.c
 wavegen_DEPENDENCIES = include/wdatutil.h include/common.h
-wavegen_LINK = $(COMPILE) -lc -lm -o $@
+wavegen_LINK = $(COMPILE) -o $@
+wavegen_LDADD = -lc -lm
 
 lp4pole_1671_so_SOURCES = lp4pole_1671.so.c lp4pole_filter.c
 pulse_1645_so_SOURCES = pulse_1645.so.c wavedata.c
@@ -324,7 +325,6 @@
 triangle_1649_so_LDFLAGS =
 am_wavegen_OBJECTS = wavegen.$(OBJEXT) wdatutil.$(OBJEXT)
 wavegen_OBJECTS = $(am_wavegen_OBJECTS)
-wavegen_LDADD = $(LDADD)
 wavegen_LDFLAGS =
 
 DEFS = @DEFS@
--- blop-0.2.8.orig/src/Makefile.am
+++ blop-0.2.8/src/Makefile.am
@@ -33,7 +33,8 @@
 noinst_PROGRAMS = wavegen
 wavegen_SOURCES = wavegen.c wdatutil.c
 wavegen_DEPENDENCIES = include/wdatutil.h include/common.h
-wavegen_LINK = $(COMPILE) -lc -lm -o $@
+wavegen_LDADD = -lc -lm
+wavegen_LINK = $(COMPILE) -o $@
 
 ## Need to specify sources so that make dist will include them
 lp4pole_1671_so_SOURCES = lp4pole_1671.so.c lp4pole_filter.c

Reply via email to