Roger Leigh wrote:
> I think it's more likely to be triggered now

It will happen by default now with mixed indep/arch packages.

One way to fix it is by adding a non-arch-specific configure target,
like this:

diff --git a/dh b/dh
index 5537db4..16cfb02 100755
--- a/dh
+++ b/dh
@@ -328,15 +328,16 @@ if (is_make_jobserver_unavailable()) {
 
 # Definitions of sequences.
 my %sequences;
-my @bd = qw{
+$sequences{configure} = [qw{
        dh_testdir
        dh_auto_configure
+}];
+$sequences{build} = [qw{
        dh_auto_build
        dh_auto_test
-};
-$sequences{build} = [...@bd];
-$sequences{'build-indep'} = [...@bd];
-$sequences{'build-arch'} = [...@bd];
+}];
+$sequences{'build-indep'} = $sequences{build};
+$sequences{'build-arch'} = $sequences{build};
 $sequences{clean} = [qw{
        dh_testdir
        dh_auto_clean
@@ -402,6 +403,8 @@ $sequences{'binary-arch'} = [...@ba, @b];
 
 # Sequence dependencies
 my %sequence_deps;
+$sequence_deps{'build-arch'} = ['configure'];
+$sequence_deps{'build-indep'} = ['configure'];
 $sequence_deps{build} = ['build-arch', 'build-indep'];
 $sequence_deps{install} = ['install-arch', 'install-indep'];
 $sequence_deps{'install-arch'} = ['build-arch'];

But, that's not the only thing to run twice. The entire set of debhelper
commands in the install and binary sequences gets run twice, with -i and
-a switches, where before they ran once with no switches. Which is
unnecessarily slow.

Particularly concerning is that dh_auto_install gets run twice, and unlike
(most) building, 2 calls to make install will do 2x the work. And running
make install twice could conceivably lead to a FTBFS too.

So I reluctantly can't apply the sequence dependencies patch in its
current state.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature

Reply via email to