On Sun, 14 Nov 2010 23:06:26 +0100, Daniel Baumann <dan...@debian.org> wrote: > On 11/14/2010 09:25 PM, Michael Hudson wrote: > > It works with -p0 :-) Apologies if I missed some convention here (the > > diff was generated with bzr, not git, so that might explain the > > difference). > > the first two changes are ok, but the second two have a typo (LH instead > of LB),
Oops, sorry about that. > and apart from the typo, i don't see why that change is usefull. > could you explain why you think it's good to do that? Well, as I said in the initial submission, it broke when using qemu-debootstrap instead of debootstrap. It's basically an implementation accident in the argument parsing of deboostrap -- if it changed to say '$# -ge 4' rather than '$4 != ""', live-build would stop working. It's all a bit theoretical and I think qemu-debootstrap is going to be fixed to be more compatible with debootstrap here, so if you think the cost to readability is too high, I can understand that. Relatedly, would you be interested in patches that move towards making live-build use qemu-deboostrap by default if cross building? I have some patches that work, but they're definitely a bit rough currently. Cheers, mwh -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
