On Mon, Aug 16, 2010 at 03:19:16AM -0400, Andres Mejia wrote: > I've setup a git repository of my own that I hope would make things easier to > review my changes. > > http://github.com/ceros/sbuild > > The branch relavant to this bug would be 'debuild-functionality'.
Hi Andres, I've been through your current changes and made some alterations. The changes are at git://git.debian.org/git/users/rleigh/sbuild (also branch debuild-functionality). - Create Host ChrootRoot in constructor, and then initialise the log streams later - deleted install_core function carried over from the merge, for some reason - removed stripping of epoch from version in set_dsc (it's automatically stripped in set_version, so could cause issues if done early--a version containing an epoch would lose the epoch) - don't open package build log until the session is started; the purpose of the package build log is to record the package build, so building the source package is not included. Also, earlier failure conditions would result in logs being mailed for trivial errors such as the wrong distribution being used, which would annoy the buildd admins. - initialised an uninitialised variable Other than these fairly minor details, the rest looks great. Could you possibly check that I've not broken anything and that it's all working correctly for you still, in particular - all pre/post-build/chroot setup/cleanup scripts work, lintian works and source packing and building all work correctly for packages with and without epochs. If you're happy that everything is working correctly, I'll merge this into the master branch. Many thanks for doing this--it's a great addition to sbuild! Many thanks, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `- GPG Public Key: 0x25BFB848 Please GPG sign your mail.
signature.asc
Description: Digital signature
