Package: initscripts
Version: 2.88dsf-12
Severity: wishlist

Here is small patch to improve error message handling.

- Display "$0" to show who is printing the message
- Generic and reusable warn(), die()

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages initscripts depends on:
ii  coreutils                     8.5-1      GNU core utilities
ii  debianutils                   3.4.1      Miscellaneous utilities specific t
ii  libc6                         2.11.2-6   Embedded GNU C Library: Shared lib
ii  lsb-base                      3.2-23.1   Linux Standard Base 3.2 init scrip
ii  mount                         2.17.2-3.3 Tools for mounting and manipulatin
ii  sysv-rc                       2.88dsf-12 System-V-like runlevel change mech
ii  sysvinit-utils                2.88dsf-12 System-V-like utilities

Versions of packages initscripts recommends:
ii  e2fsprogs                     1.41.12-2  ext2/ext3/ext4 file system utiliti
ii  psmisc                        22.11-1    utilities that use the proc file s

initscripts suggests no packages.

-- no debconf information
>From ec6f885e1bf0a15ea7d803e6141b3cf42ff3d570 Mon Sep 17 00:00:00 2001
From: Jari Aalto <[email protected]>
Date: Sun, 31 Oct 2010 22:48:52 +0200
Subject: [PATCH] debian/src/initscripts/etc/init.d/bootlogs: add warn(), die()
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


Signed-off-by: Jari Aalto <[email protected]>
---
 debian/src/initscripts/etc/init.d/bootlogs |   17 ++++++++++++++---
 1 files changed, 14 insertions(+), 3 deletions(-)
 mode change 100644 => 100755 debian/src/initscripts/etc/init.d/bootlogs

diff --git a/debian/src/initscripts/etc/init.d/bootlogs b/debian/src/initscripts/etc/init.d/bootlogs
old mode 100644
new mode 100755
index 769e644..8bebb22
--- a/debian/src/initscripts/etc/init.d/bootlogs
+++ b/debian/src/initscripts/etc/init.d/bootlogs
@@ -52,13 +52,24 @@ do_status () {
 	fi
 }
 
+warn () {
+    echo "$0: $*" >&2
+}
+
+die () {
+    status=$1
+    shift
+
+    warn "$*"
+    exit $status
+}
+
 case "$1" in
   start|"")
 	do_start
 	;;
   restart|reload|force-reload)
-	echo "Error: argument '$1' not supported" >&2
-	exit 3
+	die 3 "[ERROR] argument '$1' not supported"
 	;;
   stop)
 	# No-op
@@ -68,7 +79,7 @@ case "$1" in
 	exit $?
 	;;
   *)
-	echo "Usage: bootlogs [start|stop|status]" >&2
+	warn "Usage: bootlogs [start|stop|status]"
 	exit 3
 	;;
 esac
-- 
1.7.2.3

Reply via email to