Hi,
(cc'ing Russ since he maintains git-pbuilder)

On Mon, Oct 25, 2010 at 01:27:55AM +0200, Benoît Knecht wrote:
> Package: qemubuilder
> Version: 0.5.10
> Severity: wishlist
> Tags: patch
> 
> I'd like to propose the following patch, which adds qemubuilder support
> to git-pbuilder. With the patch applied, using qemubuilder instead of
> cowbuilder is as simple as creating a symlink to git-pbuilder. For
> example:
> 
>   git-qemubuilder -> git-pbuilder
>   git-qemubuilder-lenny -> git-pbuilder
>   git-qemubuilder-lenny-armel -> git-pbuilder
> 
> The first one selects qemubuilder as the builder, and uses the default
> distribution and architecture (sid and armel). The last form specifies
> everything explicitly.
> 
> If this patch is considered for inclusion, the following further changes
> should be considered:
> 
>  * Make git-buildpackage Suggest qemubuilder;
>  * Create a default git-qemubuilder symlink during installation;
>  * Properly document the new feature of git-pbuilder (I'll do it, but I
>    don't want to do the work before I know the patch as any chance of
>    being accepted).
> 
> I've tested the patch by calling git-pbuilder, git-qemubuilder,
> git-qemubuilder-sid and git-qemubuilder-sid-armel from git-buildpackage,
> and they all worked as expected.
> 
> This patch is also available in my git repository (commit adaaaa36):
> git://gitorious.org/debian-pkg/git-buildpackage.git

Supporting qemubuilder would be a good thing however The symlink
solution requires separate user setup (must be in $PATH) etc. I'd rather
have something that can be controlled via the environment, so we can add
options to gbp too, like:
        git-buildpackage --git-qemubuilder --git-qemu-arch=<...> ...

What do you think?
Cheers,
 -- Guido



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to