Package: blackbox Version: 0.70.1-2.2 Severity: normal Tags: patch blackbox crashes on applications that disable minimize/maximize wm functions but leave minimize/maximize wm decorations enabled. (Shouldn't happen, but also shouldn't crash the window manager.)
Crash happens when clicking on the minimize or maximize button. I suggest, instead of using an assert, to ignore these button events. Alternatively, the buttons could be decorated but crayed out. --- src/Window.cc~ 2005-10-18 10:01:41.000000000 +0200 +++ src/Window.cc 2010-10-21 20:50:32.000000000 +0200 @@ -2319,7 +2319,9 @@ } } } else { - assert(hasWindowFunction(WindowFunctionIconify)); + if (!hasWindowFunction(WindowFunctionIconify)) { + return; + } } _screen->addIcon(this); @@ -2338,7 +2340,9 @@ void BlackboxWindow::maximize(unsigned int button) { - assert(hasWindowFunction(WindowFunctionMaximize)); + if (!hasWindowFunction(WindowFunctionMaximize)) { + return; + } // any maximize operation always unshades client.ewmh.shaded = false; --------------------------------------- -- System Information: Debian Release: 5.0.6 APT prefers stable APT policy: (500, 'stable') Architecture: i386 (i686) Kernel: Linux 2.6.34 (SMP w/2 CPU cores; PREEMPT) Locale: lang=de...@euro, lc_ctype=de...@euro (charmap=ISO-8859-15) Shell: /bin/sh linked to /bin/bash Versions of packages blackbox depends on: ii libbt 0.70.1-2.2 Blackbox - shared library ii libc6 2.7-18lenny4 GNU C Library: Shared libraries ii libfontconfig1 2.6.0-3 generic font configuration library ii libgcc1 1:4.3.2-1.1 GCC support library ii libstdc++6 4.3.2-1.1 The GNU Standard C++ Library v3 ii libx11-6 2:1.1.5-2 X11 client-side library ii libxext6 2:1.0.4-2 X11 miscellaneous extension librar ii libxft2 2.1.12-3 FreeType-based font drawing librar blackbox recommends no packages. Versions of packages blackbox suggests: pn bbkeys <none> (no description available) ii menu 2.1.41 generates programs menu for all me -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org