Dear maintainer,

I have some free time and I'm offering help.

Here is the NMU diff according to DevRef 5.11.1[1][2] for bug: #530166
with other Lintian fixes according to newest policy standard.

Please let me know if it is ok to proceed with the NMU. Feel free to
contact if you have any questions.

Thank you for maintaining the package,
Jari Aalto

[1] http://www.debian.org/doc/developers-reference/pkgs.html#nmu
[2] http://dep.debian.net/deps/dep1.html

lsdiff(1) of changes:

    pvpgn-1.8.1/debian/compat
    pvpgn-1.8.1/debian/copyright
    pvpgn-1.8.1/debian/control
    pvpgn-1.8.1/debian/README.Debian
    pvpgn-1.8.1/debian/changelog
    pvpgn-1.8.1/debian/postinst
    pvpgn-1.8.1/debian/pvpgn-support-installer
    pvpgn-1.8.1/debian/init.d

diffstat for pvpgn_1.8.1-2 pvpgn_1.8.1-2.1

 README.Debian           |    5 +----
 changelog               |   25 +++++++++++++++++++++++++
 compat                  |    2 +-
 control                 |    7 ++++---
 copyright               |   42 +++++++++++++++++++++++++++++++-----------
 init.d                  |   15 ++++++++-------
 postinst                |    4 +++-
 pvpgn-support-installer |   11 ++++++-----
 8 files changed, 79 insertions(+), 32 deletions(-)

diff -u pvpgn-1.8.1/debian/compat pvpgn-1.8.1/debian/compat
--- pvpgn-1.8.1/debian/compat
+++ pvpgn-1.8.1/debian/compat
@@ -1 +1 @@
-4
+8
diff -u pvpgn-1.8.1/debian/copyright pvpgn-1.8.1/debian/copyright
--- pvpgn-1.8.1/debian/copyright
+++ pvpgn-1.8.1/debian/copyright
@@ -1,18 +1,38 @@
-This package was debianized by Robert Millan <r...@debian.org> on
-Sun, 28 Dec 2003 19:06:22 +0100.
+This package was debianized by:
 
-It was downloaded from: http://pvpgn.berlios.de/index.php?page=files
+    Robert Millan <r...@debian.org>
+    on 2003-12-28 19:06:22 +0100 Sun.
 
-Upstream Authors: the Bnetd project and others, see file CREDITS.
+It was downloaded from:
+
+    http://pvpgn.berlios.de/index.php?page=files
+    http://developer.berlios.de/projects/pvpgn
+    http://pvpgn.org/
+
+    The zlib code is not used in the debian package of pvpgn. zlib is
+    licensed under the BSD license.
+
+Upstream Authors:
+
+    The Bnetd project and others, see file CREDITS.
 
 Copyright:
 
-You are free to distribute this software under the terms of
-the GNU General Public License.
-On Debian systems, the complete text of the GNU General
-Public License can be found in /usr/share/common-licenses/GPL file.
+    Copyright (C) 2004-2010 The Bnetd project and others, see file CREDITS.
 
-zlib is licensed under the BSD license. For further information please 
-see /usr/share/common-licenses/BSD. 
-The zlib code is not used in the debian package of pvpgn.
+License:
 
+    This package is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License version 2 as
+    published by the Free Software Foundation.
+
+    This package is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+On Debian systems, the complete text of the GNU General
+Public License can be found in "/usr/share/common-licenses/GPL-2".
diff -u pvpgn-1.8.1/debian/control pvpgn-1.8.1/debian/control
--- pvpgn-1.8.1/debian/control
+++ pvpgn-1.8.1/debian/control
@@ -2,12 +2,13 @@
 Section: contrib/net
 Priority: optional
 Maintainer: Radu Spineanu <r...@debian.org>
-Build-Depends: cdbs (>= 0.4.22-1.1), debhelper (>= 4.1.0), libmysqlclient15-dev | libmysqlclient-dev, libpq-dev, autoconf, autotools-dev, zlib1g-dev
-Standards-Version: 3.7.2
+Build-Depends: cdbs (>= 0.4.22-1.1), debhelper (>= 8), libmysqlclient15-dev | libmysqlclient-dev, libpq-dev, autoconf, autotools-dev, zlib1g-dev
+Standards-Version: 3.9.1
+Homepage: http://freshmeat.net/projects/pvpgn
 
 Package: pvpgn
 Architecture: any
-Depends: ${shlibs:Depends}
+Depends: ${shlibs:Depends}, ${misc:Depends}
 Conflicts: bnetd
 Provides: bnetd
 Suggests: fortune
diff -u pvpgn-1.8.1/debian/README.Debian pvpgn-1.8.1/debian/README.Debian
--- pvpgn-1.8.1/debian/README.Debian
+++ pvpgn-1.8.1/debian/README.Debian
@@ -6,7 +6,7 @@
 
 --
 In order to function correctly with Blizzard games, pvpgn needs some
-aditional files. These files are taken verbatim from the Battle.Net servers,
+additional files. These files are taken verbatim from the Battle.Net servers,
 in violation with Blizzard's Terms of Use. Use at your own risk.
 
 To download the files, you can either use pvpgn-support-installer which 
@@ -17,3 +16,0 @@
-
-
-
diff -u pvpgn-1.8.1/debian/changelog pvpgn-1.8.1/debian/changelog
--- pvpgn-1.8.1/debian/changelog
+++ pvpgn-1.8.1/debian/changelog
@@ -1,3 +1,28 @@
+pvpgn (1.8.1-2.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * debian/compat
+    - Update deprecated 5 to 8.
+  * debian/control
+    - (Depends): Update deprecated debhelper 4 to 8.
+    - (Homepage): New.
+    - (Standards-Version): Update to 3.9.1.
+    - (pvpgn::Depends): Add ${misc:Depends}.
+  * debian/copyright
+    - Update layout. Add FSF License preamble.
+  * debian/{init.d,pvpgn-support-installer}
+    - Fix bashism, patch idea thanks to Prach Pongpanich <prach...@gmail.com>
+      with the exception that use plain echo.
+      (Closes: #530166).
+    - Clean up extra whitespaces. Move "set -e" and variable definitions
+      to the beginning of file. Prefer POSIX $(<command substitution>).
+  * debian/postinst
+    - Change "sh -e" to safer "set -e".
+  * debian/README.Debian
+    - Fix spelling typo.
+
+ -- Jari Aalto <jari.aa...@cante.net>  Thu, 21 Oct 2010 13:22:46 +0300
+
 pvpgn (1.8.1-2) unstable; urgency=low
 
   * Move the downloaded archive to /var/lib/pvpgn instead of /tmp.(doh)
diff -u pvpgn-1.8.1/debian/postinst pvpgn-1.8.1/debian/postinst
--- pvpgn-1.8.1/debian/postinst
+++ pvpgn-1.8.1/debian/postinst
@@ -1,4 +1,6 @@
-#!/bin/sh -e
+#!/bin/sh
+
+set -e
 
 #
 # Skip, if we are not in "configure" state
diff -u pvpgn-1.8.1/debian/pvpgn-support-installer pvpgn-1.8.1/debian/pvpgn-support-installer
--- pvpgn-1.8.1/debian/pvpgn-support-installer
+++ pvpgn-1.8.1/debian/pvpgn-support-installer
@@ -7,6 +7,8 @@
 # Public License, version 2 or later.
 #
 
+SUPPORT_PATH="http://download.berlios.de/pvpgn/pvpgn-support-1.0.tar.gz";
+
 usage() 
 {
 	echo "usage: pvpgn-support-installer [options]"
@@ -17,9 +19,6 @@
 		-h		-- this message"
 }
 
-SUPPORT_PATH="http://download.berlios.de/pvpgn/pvpgn-support-1.0.tar.gz";
-
-
 # look through input arguments
 until [ -z "$1" ]; do
 	case $1 in
@@ -79,7 +78,7 @@
 
 # create a temporary work directory
 echo "Creating temporary working directory..."
-TMPDIR=`mktemp -d -t pvpgn.XXXXXX` || exit 1
+TMPDIR=$(mktemp -d -t pvpgn.XXXXXX) || exit 1
 cd $TMPDIR
 
 # get the archive
@@ -105,7 +104,9 @@
 	echo "Removing temporary directory.."
 	rm -rf $TMPDIR
 	if [ ! "$OFFLINE_PATH" ]; then
-		echo -e "\n\nThe archive has been saved as /var/lib/pvpgn/pvpgn-support-1.0.tar.gz"
+		echo
+		echo
+		echo "The archive has been saved as /var/lib/pvpgn/pvpgn-support-1.0.tar.gz"
 		echo "Use pvpgn-support-installer with the -l flag if you need to reinstall"
 	fi
 fi
diff -u pvpgn-1.8.1/debian/init.d pvpgn-1.8.1/debian/init.d
--- pvpgn-1.8.1/debian/init.d
+++ pvpgn-1.8.1/debian/init.d
@@ -13,6 +13,12 @@
 # Short-Description: Gaming server that emulates Battle.net(R)
 ### END INIT INFO
 
+set -e
+
+PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
+DAEMON=/usr/sbin/bnetd
+NAME=bnetd
+DESC="bnetd daemon"
 
 # checks for the pvpgn support files
 check_support() 
@@ -30,21 +36,16 @@
 	done
 
 	if [ "$START" = "0" ]; then
-		echo -e "\nYou are missing the pvpgn support files and daemon will not start without them."
+		echo
+		echo "You are missing the pvpgn support files and daemon will not start without them."
 		echo "Run pvpgn-support-installer or read /usr/share/doc/pvpgn/README.Debian"		      
 		exit 0
 	fi
 
 }
 
-PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
-DAEMON=/usr/sbin/bnetd
-NAME=bnetd
-DESC="bnetd daemon"
-
 test -x $DAEMON || exit 0
 
-set -e
 case "$1" in
   start)
 	check_support

Reply via email to