tags 319719 + patch
thanks dude

Hello,
I think I understand now the problem. I also think how it can be
fixed properly (at least for now) but I lack the time to dive into the
gstreamer details. I created a crude patch with works and you might
use it as a workaround until someone (e.g. upstream) implements the
proper fix.

If you look into line 519 (after the comment /* Set song tags.  */)
then you see that the tags are set for gstreamer to write them out. In
the current code, the genre is set as follows:
                if (data->genre != NULL)
                        gst_tag_setter_add (GST_TAG_SETTER (data->encoder),
                                            GST_TAG_MERGE_APPEND,
                                            GST_TAG_GENRE, data->genre,
                                            NULL);

Now if track #2 comes in, "GST_TAG_MERGE_APPEND" appends the genre line. 
Hence track #2 will have 2 (!) genre entries. Track #3 will have 3
entries and so on. In the current design (see my forthcoming mail for
bug #319717) this does not make sense, as at most one genre can be
set. Now the proper fix is to change "GST_TAG_MERGE_APPEND" by the GST
flag which *OVERWRITES* the previous entry, if it exists. Since
entries like title are already handled this way, my crude patch simply
neaks genre into the first call to gst_tag_setter_add.

Looking forward for a corrected version!

(Btw. the Debian patches do not apply cleanly to goobox-0.9.92 and the
changelog does not mention genre, thats why I stayed with goobox-0.9.91.)

-- 
Dr. Helge Kreutzmann, Dipl.-Phys.           [EMAIL PROTECTED]
                       gpg signed mail preferred 
    64bit GNU powered                  http://www.itp.uni-hannover.de/~kreutzm
          Help keep free software "libre": http://www.ffii.de/

Attachment: pgpNFuXlZGgcA.pgp
Description: PGP signature

Reply via email to