Package: gconf
Version: 2.31.4-1
Severity: minor
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu natty ubuntu-patch



In Ubuntu, we've applied the attached patch to achieve the following:

  * debian/update-gconf-defaults:
    - check if a file exists before trying to read it, otherwise
      it crashes on broken symlinks (LP: #633370)

We thought you might be interested in doing the same. 

This fixes a issue we had with one package that used a symlink
in the gconf defaults directory and did not properly remove/rename
it on upgrade so that it pointed in the void. That caused 
update-gconf-defaults to raise a exception. Certainly a problem 
with the package, but it would be nice if update-gconf-defaults
would be more robust too. Thinking about it, it could print a 
big warning if it finds a not existing file.

Cheers,
 Michael

-- System Information:
Debian Release: squeeze/sid
  APT prefers maverick-updates
  APT policy: (500, 'maverick-updates'), (500, 'maverick-security'), (500, 
'maverick')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.35-22-generic (SMP w/4 CPU cores)
Locale: LANG=en_DK.utf8, LC_CTYPE=en_DK.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -u gconf-2.31.91/debian/update-gconf-defaults gconf-2.31.91/debian/update-gconf-defaults
--- gconf-2.31.91/debian/update-gconf-defaults
+++ gconf-2.31.91/debian/update-gconf-defaults
@@ -130,7 +130,8 @@
     if f.endswith(ext):
       break
   else:
-    defaults_files.append(f)
+    if os.path.exists(os.path.join(options.source_dir, f)):
+      defaults_files.append(f)
 defaults_files.sort()
 
 if options.ifchanged:
diff -u gconf-2.31.91/debian/changelog gconf-2.31.91/debian/changelog

Reply via email to