Package: perdition
Version: 1.19~rc3-1

(A look at the Mercurial repository shows that the problem is still
present in the latest upstream version.)

I noticed the following in my logs today (irrelevant information censored):
Sep 23 22:34:27 <hostname> perdition[31439]: Close: <IP1>-><IP2> 
user="<username>" received=150480 sent=-1801249610

The main problem is that perdition/io.c:io_pipe() and its caller
perdition/perdition.c:perdition_log_close() use int counters
while the corresponding arguments in vanessa_socket_pipe_func() 
are declared size_t. I'd worry about stack corruption on platforms 
where sizeof(size_t) > sizeof(int).

Suggested fix: declare those counters size_t, and (for cosmetic purposes)
cast them to unsigned long before formatting them with %lu instead of %d.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to