Hi Matthijs, On Mon, Aug 30, 2010 at 10:09:52AM +0200, Matthijs Kooijman wrote: > Hey Guido, > > > Yes. This looks really great in general, thanks alot! Two minor > > nitpicks: > Ok, nitpicks fixed. Instead of spamming this report with even more > patches, I've just pushed them here: > > http://git.stderr.nl/gitweb?p=matthijs/upstream/git-buildpackage.git > > Pull from: > > http://git.stderr.nl/matthijs/upstream/git-buildpackage.git master > > This is just the previous patches, but rebased, two new patches to > address your issues and two fixes for small bugs I noticed while moving > stuff around :-) This looks great! The only thing left is to cleanup the patch series to not fix bugs introduced earlier in the _same_ patch series. E.g. c4f184b which fixes a bug introduced earlier, just merge that. Or 02f7a2a which removes parse_changelog_file which got introduced in 4f6809de just merge that too - there's no need to have things introduced in one patch and removed in a follow up. The patch series should represent logical changes not chronological ones. The resulting tree will look 100% the same, it's just how we get there.
I can handle the cleanup but you're probaly faster, just let me know if your fed up reworking this. Cheers, -- Guido -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
