On Wed, Jul 21, 2010 at 03:41:12PM -0700, Zach Carter wrote: > schroot allows me to create a persistent session with a particular name, such > as "zcarter-catalan-build-cb67j4yZoS-16646". > However, when I attempt to access it later on, it fails like this: > > $ /usr/bin/schroot -p -v -r -c zcarter-catalan-build-cb67j4yZoS-16646 -- > uname -a > E: zcarter-catalan-build-cb67j4yZoS-16646: Chroot not found > > I traced it down to the is_valid_filename() function defined in sbuild-util.cc > > I see two solutions, either: > - enforce the same restrictions when the chroot session is first created. > - loosen the restrictions, since the run-parts() restrictions do not seem > appropriate to restrict session names. > > My vote would be for the latter solution. > > I'm attaching a patch that works for me.
Agreed on all counts and the patch looks great. I'll review it in more detail when I have time at the weekend and make a new release then. Many thanks! Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `- GPG Public Key: 0x25BFB848 Please GPG sign your mail.
signature.asc
Description: Digital signature
