On Tue, Jul 20, 2010 at 09:49:38PM +0200, Vincent Bernat wrote:
> Looking  at other  init.d scripts,  I see  they use  pidofproc  which is
> defined in /lib/lsb/init-functions.

Yes, I guess it could be used. I was not aware of this function and have not
used myself in my init.d scripts (might have to take a look at it). If I have
time I can try to rewrite/retest it with pidofproc.

> Is  it not  the job  of start-stop-daemon  to tell  that the  process is
> already running?

Yes, but start-stop-daemon does not distinguish whether it a) run the process
or b) did not run it because it was already running. I prefer to have this
information in the init.d script so as to not give a false impression to the
user telling him you started the process when, actually, you didn't need to
(or have to).

> The remaining looks fine for me. Thanks for your patch.

You are welcome.

Regards

Javier

Attachment: signature.asc
Description: Digital signature

Reply via email to