* Julian Andres Klode | 2010-06-26 20:31:34 [+0200]:

>Your patch does not make much sense. APT is written in C++, but you are
>writing raw C code (and use different function naming style).
The function's name can be renmaned to what you want. Yes it is pure C
and I kept it simple and cloned the perl routine as close as possible. I
wasn't aware that it is such a big deal. That piece of C isn't visible
from the outside and I did not introduced a warning or something like
that. The exported C++ can still be used the same way. The difference
between C++ is using libc's C-API right? Other files, like
apt-pkg/init.cc, also include C API via cstdlib. What exactly is the
problem?
On the other hand if you don't want it, don't take it, I did my best to
keep things simple :)

>Furthermore, I think it should be much easier to support this than you
>do in your patch. We just need to do replace 'any' in the architecture
>wildcard by '*' and check if it matches the current arch or the current
>arch prefixed by 'linux-' by calling fnmatch().
This will work for the linux-any but how do you know that you are linux
and not kfreebsd? For these reasons you need the debian and cpu
tripplet table so you can look it up. This is also requiered in order to
correctly match any-arm against armel or any-i386 against lpia.
So instead of implementing all this informations and rules from scratch
(and maybe introducing some bugs) I just followed existing code and used
data which is also used by dpkg.

>Regards,
>Julian
>

Sebastian



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to