On Tue, 22 Jun 2010, Guillem Jover wrote: > Unfortunately I don't think that would be acceptable for a stable > update, as some maintainers started relying on dpkg-buildpackage's > behaviour of setting those flags and stopped setting them in their > rules files. So there's a chance of regressions. If someone were to > test build the whole archive and compare results, then the SRM might > be amenable to consider it.
IMO it's time lost for almost no gain. I won't pursue this and I don't think it would right. > > I'm sorry, but I disagree with this approach. It is not right to do a > > continue doing a broken thing (one which can actually break package > > builds) "for compatibility" ! > > Right, I agree with this. More so when we have dpkg-buildflags now. > Keeping setting the flags just entrenches the current situation and > makes it worse, as I see from time to time in changelogs, maintainers > are removing the setting of the flags from debian/rules. > > I mentioned I wanted to revert the setting of the flags in a thread in > debian-devel [0] some time ago, I don't remember exactly, but I think > after discussing with Raphaël, we decided to postpone it until an > alternative solution to the centralized variable setting was provided. > The time has clearly come now, though. No, the time has not yet come, we're at the end of the squeeze cycle, we're not supposed to make such important changes. We should do it at the start of squeeze+1. And I expect "dh" to make use of dpkg-buildflags to somehow export the variables to the build system, I don't know how it will do it, but if it exports them to the environment then by not dropping the variables right now we're avoiding the second step for those packages: - variable set by /usr/bin/dpkg-buildpackage - variable not set - variable set by /usr/bin/dh Cheers, -- Raphaël Hertzog Like what I do? Sponsor me: http://ouaza.com/wp/2010/01/05/5-years-of-freexian/ My Debian goals: http://ouaza.com/wp/2010/01/09/debian-related-goals-for-2010/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
