On mar., 2010-06-22 at 12:07 +0200, Julian Andres Klode wrote:
> This spawns a new subprocess for each file, using xargs might be more
> efficient. On the other hand, the xargs solution might break if there
> are more than 2^31 - 1 files.
Right, I'm not exciting as well by spawning a process for each file, but
it seems safer (not sure about print0 would fix every corner cases)
>
> > Fixed in ubuntu, forwarding the patch to debian in a minute.
>
> Could you provide something suitable for git? A short description, less
> maximum 75 characters (including the Closes: #nnn) and a long
> description? I want to use git-dch to (semi-)auto-generate the changelog
> from the short descriptions (and not change the changelog otherwise).
[…]
sure, find it attached
> And for the future: I am subscribed to the Ubuntu bugs and we can deal
> with the Ubuntu bugs directly in a new release and sync it; there is no
> reason to do a special Ubuntu upload (or file a bug in two bug
> trackers).
The only reason is that I wanted my new evolution upload to take it.
I'll sync it as soon as you will upload a new version to Debian (I'm
looking -changes). But now that I know you are reacting fast and
subscribe, I'll directly summit your the patch :)
Regards,
Didier
>From 3b0817e1f84226e1b227185706b2b2c62216e292 Mon Sep 17 00:00:00 2001
From: Didier Roche <didro...@ubuntu.com>
Date: Tue, 22 Jun 2010 12:13:42 +0200
Subject: [PATCH] fix issue in find | xargs when files contain spaces (Closes: #586755)
When files had spaces, find | xargs md5sum was executing md5sum on the
two invalid partial filename, which resuted in md5sum exiting with the
error code 123 and making the build fail.
---
dh_autoreconf | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/dh_autoreconf b/dh_autoreconf
index 382656a..ad2e317 100755
--- a/dh_autoreconf
+++ b/dh_autoreconf
@@ -70,7 +70,7 @@ if (defined($dh{EXCLUDE_FIND}) && $dh{EXCLUDE_FIND} ne '') {
}
my %modes = (
- 'md5' => "find $find_options -type f | xargs md5sum",
+ 'md5' => "find $find_options -type f -exec md5sum {} \\;",
'timesize' => "find $find_options -type f -printf \"%s|%T@ %p\n\""
);
--
1.7.1
