hey christoph, On 11/06/2010 Christoph Anton Mitterer wrote: > I'd have written replacements for all of the current check scripts. > They should work identical to the current ones (I did some basic tests, > but please validate my code).
thanks, i've applied some changes to the check scripts in svn trunk, please take a look. unfortunately (as written in the previous mail), your scripts are cluttered. these scripts really should be as simple as possible, and the code in most cases is obvious enough that documentation isn't required. > Improvements would be: > - All other check scripts use blkid and un_blkid internally. > > - No longer depend on sed and dd (which may be not available, although this > is unlikely). > - No longer use programs, which are most likely NOT available in initramfs > images > (xfsprogs, e2fsutils). > - Better check for swap, than binary games. all of these are applied, take a look at the svn trunk. > Other changes I've made: > - No longer check for the existence of blkid (this should be always there as > util-linux > is essential/required). kept this one. > Regarding initramfs-images: > We should only add the actually used check script (if any) to it. > Should I provide a hook script for this? > We should then (if any is used) also at util-linux' blkid binary. > Should I provide a hook script for this? checks aren't supported in cryptroot at all so far. feel free to provide a patch, given that it is kept simple, small, and uses common coding style. > - Use other wording (e.g. no longer "valid filesystem" as the scripts never > check whether > the filesystem is really valid) applied. > - Give warnings with ext2, xfs, swap, vol_id and un_vol_id that they're > deprecated, and > one should switch do blkid/un_blkid. applied for ext2, xfs and swap. vol_id check scripts don't need to be depreciated. either one still has vol_id from udev available, or one doesn't. greetings, jonas
signature.asc
Description: Digital signature
