tags 585653 + patch thanks On Sat, Jun 12, 2010 at 09:43:14PM +0200, Cyril Brulebois wrote: > Source: schroot > Version: 1.4.3-1 > Severity: serious > Justification: FTBFS > > your package no longer builds on non-linux architectures: > | 1) test: test_personality::test_construction (E) > | uncaught exception of type > N6sbuild12custom_errorINS_11personality10error_codeEEE > | - Personality 'linux' is unknown > | > | > | 2) test: test_personality::test_output (E) > | uncaught exception of type > N6sbuild12custom_errorINS_11personality10error_codeEEE > | - Personality 'linux' is unknown > | > | > | FAIL: sbuild-personality > > Full build logs: > https://buildd.debian.org/status/package.php?p=schroot
Thanks for the bug. I had asked for some testing on kfreebsd prior to upload and was told it was fine; they obviously didn't run the testsuite :( If you have access to a non-Linux arch, I'd appreciate it if you could try the attached patch to see if the testsuite builds and runs OK with it applied. You can run the testsuite with 'fakeroot make check' after building though the build will run this automatically. Thanks, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `- GPG Public Key: 0x25BFB848 Please GPG sign your mail.
diff --git a/test/sbuild-personality.cc b/test/sbuild-personality.cc
index 9a1bf6c..c142dfa 100644
--- a/test/sbuild-personality.cc
+++ b/test/sbuild-personality.cc
@@ -50,11 +50,9 @@ public:
sbuild::personality p1;
CPPUNIT_ASSERT(p1.get_name() == "undefined");
- sbuild::personality p4("linux");
#if defined(SBUILD_FEATURE_PERSONALITY) && defined (__linux__)
+ sbuild::personality p4("linux");
CPPUNIT_ASSERT(p4.get_name() == "linux");
-#else
- CPPUNIT_ASSERT(p4.get_name() == "undefined");
#endif
}
@@ -67,9 +65,15 @@ public:
void
test_output()
{
+#if defined(SBUILD_FEATURE_PERSONALITY) && defined (__linux__)
sbuild::personality p4("linux");
+#else
+ sbuild::personality p4;
+#endif
+
std::ostringstream ps4;
ps4 << p4;
+
#if defined(SBUILD_FEATURE_PERSONALITY) && defined (__linux__)
CPPUNIT_ASSERT(ps4.str() == "linux");
#else
signature.asc
Description: Digital signature
