Hi *,

I had a look at the patch attached by Mats Erik. Just a few nitpicks:

| if (getaddrinfo(argv[1], "tftp", &hints, &ai) == 0)

The output of getaddrinfo in ai is never freed. One should call
freeaddrinfo(&ai). Of course this should not be a problem since this is
only called once.


| memcpy(&data.sa_peer, ai->ai_addr, ai->ai_addrlen);

Not sure about this. ai->ai_addrlen surely should not be bigger than a
struct sockaddr_in, but I'd rather play it safe and check for that before
overwriting random data.

Or at least just pass sizeof(data.sa_peer) as length parameter to memcpy.


Greetings, Torsten



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to