Package: gourmet
Version: 0.15.4-2
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu maverick ubuntu-patch
Hi Christian,
As discussed at
<http://lists.debian.org/201006052243.28438.deb...@kitterman.com>, python
2.6 does not support string exceptions. With the transition to python 2.6
by default imminent, it would be a good idea to fix gourmet to not use
string exceptions.
It looks like there will be a mass bugfiling for this issue soon, but in the
process of merging the latest gourmet package into Ubuntu maverick I
noticed that Ubuntu already has a patch for this issue, so I'm filing this
report separately with that patch. Please consider applying it at your
convenience.
The Ubuntu changelog entry corresponding to this patch is as follows:
* debian/patches/01_fix_raise_str.patch: don't raise str exception
in src/lib/plugin_gui.py
Cheers,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
=== added file 'debian/patches/01_fix_raise_str.patch'
--- debian/patches/01_fix_raise_str.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/01_fix_raise_str.patch 2010-06-06 22:20:10 +0000
@@ -0,0 +1,16 @@
+Description: fix 2.6 TypeError instead of raising bare exception
+Author: Jamie Strandboge <ja...@ubuntu.com>
+
+Index: gourmet-0.15.2/src/lib/plugin_gui.py
+===================================================================
+--- gourmet-0.15.2.orig/src/lib/plugin_gui.py 2009-12-16 07:14:22.000000000
-0600
++++ gourmet-0.15.2/src/lib/plugin_gui.py 2009-12-16 07:24:30.000000000
-0600
+@@ -124,7 +124,7 @@
+ if row[1] in dependers:
+ row[0] = False
+ else:
+- raise "Cancelled"
++ raise de.UserCancelledError("Cancelled")
+ else:
+ self.loader.deactivate_plugin_set(plugin_set)
+ except:
=== added file 'debian/patches/series'
--- debian/patches/series 1970-01-01 00:00:00 +0000
+++ debian/patches/series 2010-06-06 23:14:51 +0000
@@ -0,0 +1,1 @@
+01_fix_raise_str.patch
