tags 584285 +fixed +pending
thanks

On Fri, 2010-06-04 at 01:23 +0200, Denis Barbier wrote:
> On 2010/6/3 Adam C Powell IV wrote:
> [...]
> >> A patch will look like
> >> --- debian/rules
> >> +++ debian/rules
> >> @@ -84,7 +84,10 @@ clean:
> >>         rm -f *-stamp
> >>         dh_clean
> >>
> >> -configure-stamp:
> >> +patch-stamp:
> >> +       QUILT_PATCHES=debian/patches quilt push -a || test $$? = 2
> >> +
> >> +configure-stamp: patch-stamp
> >>         dh_testdir
> >>  #      Move aside obsolete files
> >>         for obsoletefile in KERNEL_SRC_$(SALOME_VERSION)/bin/runSalome \
> >>
> >> But there are other problems, I will try to provide working patches 
> >> tonight.
> >
> > Wonderful, thanks!
> 
> Here are several patches:
>  * 0001 is the patch mentioned above
>  * 0002 and 0003 make build abort when something goes wrong

These look fine, I've committed them.

>  * 0004 implements what is described in
> /usr/share/doc/autotools-dev/README.Debian.gz as best practice.  It is
> more complicated than I would like, because of the way upstream uses
> autotools.  It has not been fully tested.
>  * 0005 tries to make removal of generated files simpler, it has been
> even less tested.
> Thus I suggest you to commit 0001-003.  0004 could also be committed
> after review.  About 0005, you decide whether building out of source
> tree is a good idea.

Indeed, 0004 and 0005 need more review.  I'll spend some time with them
maybe this weekend.

> This will not fix all FTBFS, I also saw problems related to doxygen.
> I did not have time to investigate yet, but I believe that docs are
> also generated when running the build-arch target; doxygen will not be
> installed on autobuilders and build will fail.

Just moved it from Build-Depends-Indep to Build-Depends, hopefully that
will work.  Building now...

> Denis

-- 
GPG fingerprint: D54D 1AEE B11C CE9B A02B  C5DD 526F 01E8 564E E4B6

Engineering consulting with open source tools
http://www.opennovation.com/

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to