On 05/31/2010 06:49 AM, Julien Cristau wrote:
On Mon, May 31, 2010 at 05:12:05 +0000, Jari Aalto wrote:

    * debian/control
      - (Build-Depends): Add nvidia-glx and remove
        libgl1-mesa-dev, libglu1-mesa-dev (FTBFS; Closes: #580590).
This is utterly wrong.

Absolutely!

Jari, there's another irregularity in this upload. There is a patch for Debian version -2 in debian/patches as well as -1.1. What's up with that?

Also:

sy...@lear:~/downloads/xpilot-ng-4.7.3$ grep nvidia debian/control
sy...@lear:~/downloads/xpilot-ng-4.7.3$

Huh? Maybe the patch for -2 superceded -1.1 as it does not have the bad nvidia-glx dep.

What ever possessed you to put that dependency in there in the first place? You, yourself, said in the discussion of the bug:

   I recheck the environment and package "nvidia-glx" was causing the
   trouble. By removing it, the build succeeds. Closing.
How does removing this package from your build environment translate to adding it as a dependency in your final upload?

Please isolate your build from your personal system by using pbuilder or equivalent. Then you won't run into this kind of issue. Put the dependency back to the way it was before, fix the bad patch series, make sure the new version (-1.2) is *fully* tested, and re-upload. I appreciate the extra help as I am still quite pressed for time, but you must pay more attention to quality of your uploads or else you cost the developer extra time cleaning up your mistakes.

Thanks,
Ben

Reply via email to