On Sun, 30 May 2010 11:14:21 +0900 Mattia Dongili wrote: > On Sun, May 30, 2010 at 10:46:25AM +0900, Mattia Dongili wrote: > > severity 583663 important > > tags 583663 - patch > > > > On Sat, May 29, 2010 at 01:18:09PM +0200, Francesco Poli (t1000) wrote: > ... > > > I am under the impression that this bug is due to incomplete LSB header > > > dependencies: the attached patch seems to fix the issue. > > > > I don't think that is correct. cpufreqd.init has its own code to load > > cpu and governor modules.
Ooops, I wasn't aware of this: I hadn't read the whole init.d script (shame on me!) and I just thought cpufreqd relied on loadcpufreq to load kernel modules (except for monolithic kernels or modules force-loaded by some other means). Sorry for the bogus patch, then... :p [...] > actually I can imagine what happened. You always relied on cpufrequtils > to load the kernel modules and never configured /etc/default/cpufreqd. Bingo! After setting CPUFREQ_CPU_MODULE="powernow_k7" in /etc/default/cpufreqd everything seems to work correctly again. Thanks for clarifying! :-) > There is not much that I can do for that other than duplicating the > approach in cpufrequtils or depending on it (which is wrong and usually > generates confusion). > > I guess the only other viable approach is to distribute loadcpufreq.init > in libcpufreq0 and depend on it in cpufreqd. I think that relying on some automatic module loading code would be a great improvement for cpufreqd: I mean, why ask the user to specify which kernel module should be loaded, when some code may probe the hardware and figure out automatically? In order to avoid code duplication, I think that cpufreqd could exploit loadcpufreq, rather than reinventing the wheel with its own implementation. After all, cpufreqd suggests cpufrequtils, so it should work well on systems where cpufrequtils is also installed: but on those systems, two separate init.d scripts attempt to load cpufreq kernel modules, which is awkward... Maybe this bug report should be converted into a wishlist bug requesting for the above-described change... P.S.: Mattia and Petter, thanks to both of you for your quick replies! -- http://www.inventati.org/frx/progs/scripts/pdebuild-hooks.html Need some pdebuild hook scripts? ..................................................... Francesco Poli . GnuPG key fpr == C979 F34B 27CE 5CD8 DC12 31B5 78F4 279B DD6D FCF4
pgptWltRiNQjD.pgp
Description: PGP signature
