Hello Dmitrijs,
On Mon, May 24, 2010 at 14:24, Dmitrijs Ledkovs
<dmitrij.led...@ubuntu.com> wrote:
> Here is the current dsc ready for upload to Debian (with last minute
> fixes to debrand package description)
>
> http://mentors.debian.net/debian/pool/main/u/usb-creator/usb-creator_0.2.23.dsc
>
> also pushed as a branch lp:~dmitrij.ledkov/usb-creator/debian
> (temporary branch intended to be merged with lp:usb-creator)
Excellent job. Howerver, it seems that the version 0.2.23 has not been
released by upstream yet. I prefer waiting for the new release before
trying to upload it to Debian.
Here are the options I see:
1- Wait for the 0.2.23 version to be released upstream, and take
action from this version and on.
2- Work on the 0.2.22 version (as I did because I wasn't aware 0.2.23
was about to be released) then upload the newer version later.
I would prefer option 1, tell me what you think.
> The maintainer is currently set as Ubuntu Installer Team as these
> Ubuntu & Debian Developers have actually created and maintained this
> package.
As we will be maintaining this package for Debian, we will set
ourselves in the Maintainer and Uploaders fields.
> I'm GSoC'2010 student working on usb-creator this summer and I have a
> have upload rights after review from mentor / primary upstream author
> Evan.
Ooh, congrats! This is excellent! :)
> Please review packaging above and if there are any issues I believe we
> will be able to work them out and upload to debian soon.
Here are my thoughts:
---
* debian/changelog:
- it is missing the Initial Debian release closing the 2 ITPs
(Debian specific).
---
* debian/control:
- Maintainer field should be updated as the Ubuntu Installer Team
won't be the Debian maintainer of the usb-creator package (Debian
specific).
- It seems kdesdk-scripts is missing from the build dependencies as
extractrc(1) (which it provides) is used by Messages.sh. Is this an
upstream bug?
---
* debian/usb-creator-gtk.menu and debian/usb-creator-kde.menu files
are missing. Is this an upstream bug?
---
* .desktop files:
- I am not convinced that usb-creator's Desktop file should appear
in "System/Administration" as using it does not have an effect on the
local system. I'd rather put it in "Application/System tools".
What do you think about this?
---
* debian/rules:
- I am not sure that this is the best way to go (using dpkg-vendor
there), but I can't think of better way to do it. :)
- I have updated the find executions to use absolute path.
- I also changed the override from dh_install to dh_auto_install.
I have uploaded a new version [1]. Tell me what you think about it.
I am, of course, open to all your suggestions. :)
Cheers,
Ignace M
[1] http://ghantoos.org/misc/debian/usb-creator_0.2.23.dsc
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
