Package: sgt-puzzles
Version: 8853-2
Severity: important
Tags: patch
User: debian-p...@lists.debian.org
Usertags: perl-5.12-transition

This package fails to build on amd64 with perl 5.12.1-1 from experimental:

  touch debian/stamp-patched
  /mkfiles.pl
  /usr/bin/make "VER=-DREVISION=8853" \
              "XFLAGS=-DDEBIAN_VERSION=\"\\\"8853-2\\\"\" 
-DHELP_BROWSER_PATH=\"\\\"yelp:khelpcenter:sensible-browser\\\"\"" \
              puzzles
  make[1]: Entering directory 
`/build/niko-sgt-puzzles_8853-2-amd64-fJRtwP/sgt-puzzles-8853'
  make[1]: *** No rule to make target `puzzles'.  Stop.
  make[1]: Leaving directory 
`/build/niko-sgt-puzzles_8853-2-amd64-fJRtwP/sgt-puzzles-8853'
  make: *** [build-arch-stamp] Error 2
  dpkg-buildpackage: error: debian/rules build gave error exit status 2
 
Patch attached. You might want to have a look at the other warnings
reported by 'perl -w mkfiles.pl' too.
-- 
Niko Tyni   nt...@debian.org
>From 2bb941340c860b80b87ceee4f63b7832ca9e1c43 Mon Sep 17 00:00:00 2001
From: Niko Tyni <nt...@debian.org>
Date: Sun, 23 May 2010 14:50:27 +0300
Subject: [PATCH] Fix mkfiles.pl breakage with Perl 5.12

Splitting to @_ in a void context has been deprecated since Perl 5.6.1
and support for it was finally removed in 5.12.0. Adjust mkfiles.pl
accordingly.
---
 mkfiles.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mkfiles.pl b/mkfiles.pl
index 7f36f8f..6087e50 100755
--- a/mkfiles.pl
+++ b/mkfiles.pl
@@ -56,7 +56,7 @@ readinput: while (1) {
   }
 
   chomp;
-  split;
+  @_ = split;
 
   # Skip comments (unless the comments belong, for example because
   # they're part of a diversion).
-- 
1.7.1

Reply via email to