Hi Jonas, On Sat, May 22, 2010 at 3:55 PM, Jonas Smedegaard <jo...@jones.dk> wrote:
> On Thu, May 20, 2010 at 03:33:52PM -0500, Rudy Godoy wrote: > > Please add cdbs_curpkg for DEB_DH_INSTALLINIT_ARGS. Currently it >> does apply for each target binary package. >> > > Ah, stupid me [asking for a patch without noticing that indeed you already > provided one] :-P > > Thanks for the patch! It is flawed, so a good example of how small changes > can go bad: You _replace_ DEB_DH_INSTALLINIT_ARGS with the package-specific > variant of it. The proper would be to still use DEB_DH_INSTALLINIT_ARGS as > fallback. > > I'm afraid I'm a bit lost on this. You can blame my re-involvement. > But flawed or not - it helps me more clearly understand exactly what is > your needs. Now I'll do my best to fix it to not hurt potential needs of > others. :-) > > Great. > ...and while we are at it: It won't hurt to also add an *_ALL variant which > is always applied, in addition to either the main variable or the > package-specific override. I.e. use the (also recently added) > cdbs_expand_curvar. > > Great. As I put on my report, the current behabiour doesn't actually hurt, however it doesn't make much sense to also pass it to packages who are not installing an init script. regards, Rudy -- Rudy Godoy http://htu.pe - Internet Software
