Source: xchat
Version: 2.8.6-6
Severity: wishlist
Tags: patch
User: pkg-tcltk-de...@lists.alioth.debian.org
Usertags: UpgradeDefaultTclTkTo85

Hi Davide and Bart,

To help find problems that arise before making this change for real,
it would be nice to have most packages depending on tcl-dev built
against version 8.5 in experimental.

I rebuilt xchat locally with this patch applied and the result seemed
to run okay, but of course that does not mean much.  Any idea where
I should look for scripts to run to make sure it is not broken?

While at it, I fixed two other problems I ran into:

 - xchat Recommends: the tcl and python (default version) packages,
   but the tcl.so and python.so plugins are linked against specific
   versions.  This means that whenever the default tcl or python
   version changes, that dependency would be wrong.

 - xchat Build-Depends: the tcl-dev (default version) package but
   tells the configure script to look for /usr/lib/tcl8.4/tclConfig.sh.
   This will cause failures to build from source as soon as the
   default version changes.

If you would like, I would be glad to file separate bugs for them.

The build-depends changes (to use tcl-dev (>= 8.5) and tcl (>= 8.5))
are meant for experimental only; their only purpose is to get the
fussy experimental buildds to use tcl from experimental[1][2].
Without the tcl build-dep, the result would be a failed build from
unsatisfiable dependencies.

Patch is against version 2.8.6-6 from sid but intended for
experimental.  If an NMU would be simpler, please let me know and I
can try to find a sponsor.

Thoughts?
Jonathan

[1] http://lists.debian.org/debian-release/2010/03/msg00303.html
[2] http://lists.debian.org/debian-devel-announce/2006/04/msg00007.html

 debian/changelog |    9 +++++++++
 debian/control   |    4 ++--
 debian/rules     |    8 ++++++--
 3 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 8d5605a..205c1d8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+xchat (2.8.6-7) experimental; urgency=low
+
+  * Fix Recommends to point to specific tcl and python versions.
+  * debian/rules: use --enable-tcl=/usr/lib instead of /usr/lib/tcl8.4.
+    This should prevent build failures if the default tcl version changes.
+  * Rebuild against tcl-dev from experimental.
+
+ -- Jonathan Nieder <jrnie...@gmail.com>  Wed, 19 May 2010 20:12:41 -0500
+
 xchat (2.8.6-6) unstable; urgency=medium
 
   * The "Death Star" release.
diff --git a/debian/control b/debian/control
index e66d196..660ee3f 100644
--- a/debian/control
+++ b/debian/control
@@ -4,7 +4,7 @@ Priority: optional
 Maintainer: Davide Puricelli (evo) <e...@debian.org>
 Uploaders: Bart Martens <ba...@debian.org>
 Standards-Version: 3.8.4.0
-Build-Depends: debhelper (>= 5), bison, libssl-dev, libglib2.0-dev, 
libgtk2.0-dev (>= 2.0.6), libperl-dev, gettext (>= 0.10.37), libtool, 
zlib1g-dev, perl (>= 5.8), python-dev, tcl-dev, autotools-dev, dpatch, 
libdbus-glib-1-dev, libgtkspell-dev, gconf2, dpkg-dev (>= 1.13.19), 
libsexy-dev, chrpath, imagemagick
+Build-Depends: debhelper (>= 5), bison, libssl-dev, libglib2.0-dev, 
libgtk2.0-dev (>= 2.0.6), libperl-dev, gettext (>= 0.10.37), libtool, 
zlib1g-dev, perl (>= 5.8), python-dev, tcl-dev (>= 8.5), tcl (>= 8.5), 
autotools-dev, dpatch, libdbus-glib-1-dev, libgtkspell-dev, gconf2, dpkg-dev 
(>= 1.13.19), libsexy-dev, chrpath, imagemagick
 Homepage: http://www.xchat.org/
 
 Package: xchat
@@ -12,7 +12,7 @@ Architecture: any
 Provides: irc
 Replaces: xchat-gnome (<< 1:0.11-1), xchat-common (<< 1.6.0-1)
 Depends: ${shlibs:Depends}, xchat-common (= ${source:Version}), ${misc:Depends}
-Recommends: python, tcl, esound-clients | alsa-utils, libnotify1 | 
libnotify-bin, xdg-utils
+Recommends: ${shlibs:Recommends}, esound-clients | alsa-utils, libnotify1 | 
libnotify-bin, xdg-utils
 Conflicts: xchat-gnome (<< 1:0.11-1)
 Description: IRC client for X similar to AmIRC
  XChat is a graphical IRC Client with a GTK+ GUI. It has a look and feel
diff --git a/debian/rules b/debian/rules
index 7d89aca..ef3f936 100755
--- a/debian/rules
+++ b/debian/rules
@@ -20,7 +20,7 @@ configure-stamp:
        cp -f /usr/share/misc/config.guess .
        [ -f xchat.xpm ] || convert -resize 32x32 xchat.png xchat.xpm
        CFLAGS="$(CFLAGS)" ./configure --prefix=/usr --sysconfdir=/etc 
--enable-python --enable-ipv6  \
-       --disable-mmx --enable-openssl --enable-tcl=/usr/lib/tcl8.4  \
+       --disable-mmx --enable-openssl --enable-tcl=/usr/lib  \
        --enable-dbus --disable-rpath
        touch configure-stamp
 
@@ -92,7 +92,11 @@ endif
        dh_compress -pxchat
        dh_fixperms -pxchat
        dh_installdeb -pxchat
-       dh_shlibdeps -pxchat -Xpython.so -Xtcl.so
+       dh_shlibdeps -pxchat -Xpython.so -Xtcl.so -- \
+               -dRecommends \
+               debian/xchat/usr/lib/xchat/plugins/tcl.so \
+               debian/xchat/usr/lib/xchat/plugins/python.so \
+               -dDepends
        dh_gencontrol -pxchat
        dh_md5sums -pxchat
        dh_builddeb -pxchat
-- 
1.7.1




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to