tag 579032 patch
thanks
On Sat, Apr 24, 2010 at 06:32:06PM +0300, Niko Tyni wrote:
> Package: libsocialtext-wikitest-perl
> Version: 0.06-3
> Severity: important
> User: debian-p...@lists.debian.org
> Usertags: perl-5.12-transition
>
> This package fails to build with perl_5.12.0-1 from experimental:
> # $got->[1] = (?s-xim:pen?)
> # $expected->[1] = (?-xism:pen?)
Proposed patch attached, this works for me on both 5.10.1 and 5.12.0.
I've sent a similar one upstream.
Comparing qr// things with test_deeply() before 5.12 is really broken, see
http://rt.cpan.org/Public/Bug/Display.html?id=53469
--
Niko Tyni nt...@debian.org
>From e0cff84c2b9c4bd5efe520baa52eee28f62c564a Mon Sep 17 00:00:00 2001
From: Niko Tyni <nt...@debian.org>
Date: Fri, 14 May 2010 09:56:02 +0300
Subject: [PATCH] Fix a test failure with Perl 5.12.0 due to improved regexp comparisons
The regexp implementation changed in the Perl 5.11 series, and
test_deeply() now compares them more carefully, as shown by
perl -MTest::More=no_plan -e 'is_deeply(qr/a/s, qr/a/)'
---
t/fixture-selenese.t | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/fixture-selenese.t b/t/fixture-selenese.t
index 4e9f6d0..c83b720 100644
--- a/t/fixture-selenese.t
+++ b/t/fixture-selenese.t
@@ -29,9 +29,9 @@ EOT
[ title_like => qr/\Qmonkey\E/ ],
[ text_like => ['//body', qr/\Qwater\E/] ],
[ text_like => ['//body', qr/\Qpen?\E/] ],
- [ text_like => ['//body', qr/pen?/] ],
+ [ text_like => ['//body', qr/pen?/s] ],
[ confirmation_like => qr/\Qpen?\E/ ],
- [ confirmation_like => qr/pen?/ ],
+ [ confirmation_like => qr/pen?/s ],
[ click_ok => 'foo' ],
[ wait_for_page_to_load_ok => 10000 ],
],
--
1.7.1
