-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/12/2010 05:24 PM, Olly Betts wrote: > On Fri, May 07, 2010 at 09:05:55PM -0700, tony mancill wrote: >> + * debian/rules >> + - (build-stamp): Check that DISPLAY is set before running tests. >> [...] >> - $(MAKE) check >> + [ ! "$DISPLAY" ] || $(MAKE) check > > I don't understand the need for this change. What error were you getting that > motivated this change? > > The only test script which seems to run anything which might use X is > tests/smoketest.tst, and in there testing of aven is already protected by: > > if test -n "$DISPLAY" && test -r "$testdir"/../src/aven ; then > > The only other tested binary which uses X is xcaverot, and it looks to me like > xcaverot processes --help and --version before calling XOpenDisplay, so I'm > not > seeing why that would need an X display here. If it really does, the attached > patch would be a much better fix than disabling the whole testsuite. > > Cheers, > Olly
Hi Olly, Jari made the change because I was getting failures trying to build the package inside a chroot environment, but it didn't affect the build. I ended up unsetting my DISPLAY before the build. I agree that it would be better not to disable the entire test suite; I'll test with your patch. Thank you, Tony -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkvrYzcACgkQpdwBkPlyvgNDLACfdbMrkZpm3w5/kh2biGrgeXB3 xaUAn2uDqe3tiLnDXF79xQiEaW6YQpVD =PLOE -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
