Package: reportbug-ng Version: 1.21 Severity: minor Tags: patch When using Reportbug-NG with a dark/inverted desktop theme, some colors are not properly set:
- The "normal" color for the query result list is stuck to
black, regardless of the value for this color in the
settings.
- The "Using Reportbug-NG" welcome text has black foreground
color, whereas the background is not set and therefore defaults
to "transparent" resulting in the default window background color.
Attached is a patch, that actually uses the 'c_normal' setting for the
query results by default and fixes both background and foreground in
the "Using" snippet.
Regards,
Philipp
--- System information. ---
Architecture: i386
Kernel: Linux 2.6.32-5-686
Debian Release: squeeze/sid
500 unstable www.debian-multimedia.org
500 unstable ftp.de.debian.org
500 testing security.debian.org
500 testing ftp.de.debian.org
500 stable security.debian.org
500 stable ftp.de.debian.org
100 experimental ftp.de.debian.org
--- Package information. ---
Depends (Version) | Installed
================================-+-============
python | 2.5.4-9
python-support (>= 0.90.0) | 1.0.8
python-debianbts (>= 1.0) | 1.4
python-qt4 | 4.7.3-1
xdg-utils | 1.0.2+cvs20100307-1
xterm | 258-1
python-apt (>= 0.7.93) | 0.7.94.2
From 2336e017af3181d1ea03dc4080dc721d217b8711 Mon Sep 17 00:00:00 2001
From: Philipp A. Hartmann <p...@sorgh.de>
Date: Wed, 12 May 2010 11:34:28 +0200
Subject: [PATCH] use "Normal" color by default, fixed colors in "Using"
When using Reportbug-NG with a dark/inverted desktop theme,
some colors are not properly set.
For the query result list, all colors are meant to be
configurable, but the 'c_normal' color has not been used
anywhere.
For the initial "Using Reportbug-NG" text, fixed colors
are set for now. They may be set to proper system colors
in the future.
Signed-off-by: Philipp A. Hartmann <p...@sorgh.de>
---
src/rnggui.py | 2 +-
src/rnghelpers.py | 6 ++++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/rnggui.py b/src/rnggui.py
index 0281411..3c3efb5 100644
--- a/src/rnggui.py
+++ b/src/rnggui.py
@@ -470,7 +470,7 @@ class TableModel(QtCore.QAbstractTableModel):
if role == QtCore.Qt.ForegroundRole:
severity = self.elements[index.row()].severity.lower()
done = self.elements[index.row()].done
- c = QtCore.Qt.black
+ c = self.parent.settings.c_normal
if severity == "grave":
c = self.parent.settings.c_grave
elif severity == "serious":
diff --git a/src/rnghelpers.py b/src/rnghelpers.py
index bf7aeb6..208ce6c 100644
--- a/src/rnghelpers.py
+++ b/src/rnghelpers.py
@@ -100,7 +100,9 @@ def getSeverityExplanation(severity):
def getRngInstructions():
"""Return translated instructions for reportbug ng."""
- return QCoreApplication.translate("rnghelpers", """<h2>Using Reportbug-NG</h2>
+ # TODO: use system colors?
+ return """<div style="background: #fff; color: #000;" >""" + \
+ QCoreApplication.translate("rnghelpers", """<h2>Using Reportbug-NG</h2>
<h3>Step 1: Finding Bugs</h3>
<p>To find a bug just enter a query and press Enter. Combinations of multiple \
queries are supported, e.g.: "severity:grave tag:patch".</p>
@@ -125,7 +127,7 @@ affects the packagename, bugnumber, summary, status and severity of a bug.</p>
<h3>Step 3: Reporting Bugs</h3>
<p>You can either provide additional information for an existing bug by clicking on the bug in the list and pressing the "Additional Info" button or you can create a new bugreport for the current package by clicking the "New Bugreport" button.</p>
-""")
+""") + """</div>"""
def getAvailableMUAs():
"""
--
1.7.1
signature.asc
Description: OpenPGP digital signature
