Sorry for the huge delay ... > * Thomas Lange <la...@informatik.uni-koeln.de> [Mon Mär 29, 2010 at 03:07:08 > +0200]: > > > People like to use setup-storage without calling it from FAI. > > FullACK :) >
I'm fine with that! Mika's patch is included in 3.4~beta1+experimental2 (with
minor tweaking of versioned conflicts with fai-client to (<< 3.4~)). But I still
have a few comments, see below.
> > This is how it should work
>
> > - install the fai-client package
> > - export PATH=/usr/lib/fai:${PATH}
> > - export disklist=$(disk-info | sort)
> > - setup-storage -X -f yourconfigfile
>
> JFTR: $LOGDIR needs to be set as well.
>
> Example session with adjusted /usr/share/fai/setup-storage/Fstab.pm:
>
> | mkdir /tmp/foo
> | export LOGDIR=/tmp/foo
> | export disklist=$(/usr/lib/fai/disk-info | sort )
> |
> | cat > template << EOF
> | disk_config sda
> | primary /boot 40 ext3 rw
> | primary swap 40 swap sw
> | EOF
> |
> | setup-storage -X -f template
>
I guess I'll add this to the man page, if I may?
> /usr/share/fai/setup-storage/Fstab.pm has been manually adjusted
> because it invokes fai-vol_id without full path and I don't have
> /usr/lib/fai in my $PATH.
>
This should be fixed, but see below.
> As discussed via IRC I'd strongly favor providing setup-storage as
> separate Debian package, because:
>
> * it improves the options to set the according dependencies in the
> Debian package
>
> * people who don't use FAI but need a tool like setup-storage might
> consider using it (and as a consequence providing a larger user
> base to setup-storage as well as possibly FAI)
>
> I've started to work on the initial packaging against current svn
> trunk of FAI:
>
> http://grml.org/tmp/split-out-setup-storage.patch
>
Thanks a lot for doing all the work!! As I said above, I just tweaked the
versioned conflicts.
> I'm not really happy to manually have to adjust $PATH so
> /usr/share/fai/setup-storage/Fstab.pm finds /usr/lib/fai/fai-vol_id.
> Would it be an option to provide a simple wrapper which sets $PATH,
> $disklist and $LOGDIR to sane defaults (if not set already) and
> provides all the cmdline arguments to setup-storage 1:1? (I'd work
> on that, so I just request for an [N]ACK ;))
>
- The paths: I think we should move at least fai-vol_id to
/usr/share/fai/setup-storage (and use the full path in Fstab.pm).
Should we do so for disk-info as well? But disk-info is used several times, so
this is up to Thomas to decide.
- In fact, we should at least have all the stuff in /usr/share/fai (it's all
arch-indep), but that's probably a different story.
- Should we simply change setup-storage to set LOGDIR to some temporary dir and
run disk-info if either of the variables is not yet set? I believe this
doesn't even warrant a separate wrapper.
> Thomas and Michael Tautschnig, I'd especially appreciate your
> feedback - what do you think about it?
>
In general: great; we just need to iron out all the details.
Best,
Michael
pgpVAwg3juJPG.pgp
Description: PGP signature
