On 03/04/10 22:43, Jonathan Nieder wrote:
Source: dnprogs
Version: 2.50.1

Hi Christine,

As you probably know, GCC 4.4 is more aggressive by default than
previous versions about taking advantage of C99 aliasing rules to speed
up code [1].  Building dnprogs produces warnings related to this
regarding dnet_pton1 (dnet_pton.c line 60) and dnet_ntop1 (dnet_ntop.c
line 49).

Problems from unexpected optimization can be hard to debug, so I thought
I should check in with you about these.

A quick fix is to disable the optimization with -fno-strict-aliasing.
Of course, it is much better to fix the strict aliasing violation
itself, by copying char by char (e.g., with memcpy), using a union to
make the aliasing explicit, or paraphrasing the code to avoid
type-punning altogether.

I noticed this while trying to build your package under hercules (s390
emulator).  It’s still chugging away.

Please let me know if there is any more information I can provide to
help track this down.



Hiya,

Thanks for the report. I think I'll replace those lines with a memcpy for safety. It's what I've done in a few other places - mainly where it broke on SPARC ;-)

I have some other patches for DECnet queued up so I'll include this in that update, hopefully in the coming week.

Chrissie



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to