Package: ripit
Version: 3.8.0-1
Severity: normal
File: /usr/bin/ripit

Hi,

When ran with --mb, ripit assumes that the discid command is available, which
is not the case.

I'm attaching a trivial patch to add a dependendency on cd-discid and add a
patch so that ripit runs cd-discid, instead of discid.

Cheers,
Serafeim

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (100, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.30-2-686 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=el_GR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages ripit depends on:
ii  cdparanoia               3.10.2+debian-9 audio extraction tool for sampling
ii  libcddb-get-perl         2.27-1          Perl interface to read the CDDB en
ii  libwebservice-musicbrain 0.93-1          XML based Web service API to the M
ii  libwww-perl              5.834-1         Perl HTTP/WWW client/server librar
ii  normalize-audio          0.7.7-6         adjusts the volume of WAV, MP3 and
ii  vorbis-tools             1.2.0-6         several Ogg Vorbis tools

ripit recommends no packages.

Versions of packages ripit suggests:
ii  eject           2.1.5+deb1+cvs20081104-7 ejects CDs and operates CD-Changer
pn  id3             <none>                   (no description available)
pn  id3v2           <none>                   (no description available)

-- no debconf information
diff -Nurp ripit-3.8.0.orig//debian/control ripit-3.8.0/debian/control
--- ripit-3.8.0.orig//debian/control	2010-03-27 20:40:37.000000000 +0100
+++ ripit-3.8.0/debian/control	2010-03-27 20:42:00.000000000 +0100
@@ -13,7 +13,8 @@ Depends: libwww-perl, libcddb-get-perl,
          cdparanoia | cdda2wav,
          vorbis-tools (>= 1.0beta4-1) | lame | flac | bladeenc | faac,
          normalize-audio,
-         libwebservice-musicbrainz-perl
+         libwebservice-musicbrainz-perl,
+         cd-discid
 Suggests: eject, id3 (>= 0.12), id3v2
 Description: Textbased audio cd ripper
  ripit runs in text mode (no fancy GUI here) and does everything required to
diff -Nurp ripit-3.8.0.orig//debian/patches/fix-discid-invocation.patch ripit-3.8.0/debian/patches/fix-discid-invocation.patch
--- ripit-3.8.0.orig//debian/patches/fix-discid-invocation.patch	1970-01-01 01:00:00.000000000 +0100
+++ ripit-3.8.0/debian/patches/fix-discid-invocation.patch	2010-03-27 20:47:12.000000000 +0100
@@ -0,0 +1,11 @@
+--- a/ripit.pl
++++ b/ripit.pl
+@@ -1051,7 +1051,7 @@
+    }
+ 
+    if($mb == 1) {
+-      open(DISCID, "discid $scsi_cddev|");
++      open(DISCID, "/usr/bin/cd-discid $scsi_cddev|");
+       my @response = <DISCID>;
+       close DISCID;
+       chomp($cd{discid} = join("", grep(s/^DiscID\s*:\s//, @response)));
diff -Nurp ripit-3.8.0.orig//debian/patches/series ripit-3.8.0/debian/patches/series
--- ripit-3.8.0.orig//debian/patches/series	2010-03-27 20:40:37.000000000 +0100
+++ ripit-3.8.0/debian/patches/series	2010-03-27 20:43:11.000000000 +0100
@@ -1,2 +1,3 @@
+fix-discid-invocation.patch
 normalize.patch
 makefile.patch

Reply via email to