Hi,

thanks for your patch. However I think it's slightly "wrong".
You are using dpatch without having dpatch as build-depend.
When you have dpatch as b-d, why not use /usr/share/dpatch/dpatch.make 
and it's magic targets?
Using 
build-stamp: patch-stamp
clean: unpatch
should be enough (you do not need to unclean before unpatching, because 
you are not patching any makefiles or smth involved in the clean 
process).

*However* I'd not use dpatch at all here.
Maintainer already has direct changes to files in his .diff.gz 
(lib/diakonos.rb and lib/diakonos/help.rb) and I think forcing him to 
some patch system he is not (yet) using is the wrong way *here* (don't 
understand me wrong, I'm all for patch systems [even if I prefer quilt 
over dpatch] but here we are not the maintainer and should adapt his 
workflow).

Regards,
Evgeni

PS: if you want, i can upload the patch/NMU after you fixed the point(s) 
above :)

-- 
Bruce Schneier can read and understand Perl programs.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to